Consistently use logutils.TypeAttr #49948
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When converting to slog there have been various mechanisms used to include an objects type in a slog attribute to replace %T from a logrus message. This unifies all type attribute to use logutils.typeAttr instead of calling reflect/fmt directly. The former ensures that the type is only calculated if the message is going to be logged.
rosstimothy
added
the
no-changelog
zmb3
approved these changes
Dec 9, 2024
kopiczko
approved these changes
Dec 9, 2024
public-teleport-github-review-bot
bot
removed the request for review
from probakowski
|
@rosstimothy See the table below for backport results.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When converting to slog there have been various mechanisms used to include an objects type in a slog attribute to replace %T from a logrus message. This unifies all type attribute to use logutils.typeAttr instead of calling reflect/fmt directly. The former ensures that the type is only calculated if the message is going to be logged.