Convert lib/srv/transport to use slog #49914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosstimothy
force-pushed
the
tross/srv_transport_slog
branch
2 times, most recently
from
396c618 to
0bcef1a
Compare
smallinsky
approved these changes
Dec 9, 2024
| @@ -262,7 +263,7 @@ func (s *Service) ProxySSH(stream transportv1pb.TransportService_ProxySSHServer) | |||
| case *transportv1pb.ProxySSHRequest_Agent: | |||
| agentStream.incomingC <- frame.Agent.Payload | |||
| default: | |||
| s.cfg.Logger.Errorf("received unexpected ssh frame: %T", frame) | |||
| s.cfg.Logger.ErrorContext(ctx, "received unexpected ssh frame", "frame", reflect.TypeOf(frame)) | |||
There was a problem hiding this comment.
Suggested change
| s.cfg.Logger.ErrorContext(ctx, "received unexpected ssh frame", "frame", reflect.TypeOf(frame)) | |
| s.cfg.Logger.ErrorContext(ctx, "received unexpected ssh frame", "frame", fmt.Sprintf("%T", frame))) |
There was a problem hiding this comment.
Better yet:
Suggested change
| s.cfg.Logger.ErrorContext(ctx, "received unexpected ssh frame", "frame", reflect.TypeOf(frame)) | |
| s.cfg.Logger.ErrorContext(ctx, "received unexpected ssh frame", "frame", logutil.TypeAttr(frame)) |
There was a problem hiding this comment.
I've also opened https://github.com/gravitational/teleport.e/pull/5655 and #49948 to convert every existing fmt/reflect call to use logutils.TypeAttr.
rosstimothy
force-pushed
the
tross/srv_transport_slog
branch
from
3f0c17f to
02fdcf2
Compare
zmb3
approved these changes
Dec 9, 2024
public-teleport-github-review-bot
bot
removed the request for review
from bl-nero
rosstimothy
force-pushed
the
tross/srv_transport_slog
branch
from
02fdcf2 to
dfc4e43
Compare
rosstimothy
added
the
no-changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.