-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add redirect for graphql-js #1798
Conversation
@JoviDeCroock is attempting to deploy a commit to the The GraphQL Foundation Team on Vercel. A member of the Team first needs to authorize it. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about all the subpaths; are we leaving them as-is or are we redirecting those too?
Going to improve these redirects a bit more, sec |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me - should I merge it @JoviDeCroock?
{ | ||
"source": "/graphql-js/graphql-http", | ||
"destination": "https://graphql-js.org/api-v16/graphql-http", | ||
"permanent": true | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this the right place for graphql-http documentation?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure honestly, I'm not sure it belongs in graphql-js even 😅
As soon as we cut the domain over for https://graphql-js.org to the new content we can put this redirect in place.