Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add redirect for graphql-js #1798

Merged
merged 3 commits into from
Jan 18, 2025

Conversation

JoviDeCroock
Copy link
Member

As soon as we cut the domain over for https://graphql-js.org to the new content we can put this redirect in place.

Copy link

vercel bot commented Oct 20, 2024

@JoviDeCroock is attempting to deploy a commit to the The GraphQL Foundation Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

vercel bot commented Oct 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
graphql-github-io ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 15, 2025 4:38pm

Copy link
Member

@benjie benjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about all the subpaths; are we leaving them as-is or are we redirecting those too?

@JoviDeCroock
Copy link
Member Author

Going to improve these redirects a bit more, sec

Copy link
Member

@benjie benjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me - should I merge it @JoviDeCroock?

Comment on lines +48 to +52
{
"source": "/graphql-js/graphql-http",
"destination": "https://graphql-js.org/api-v16/graphql-http",
"permanent": true
},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this the right place for graphql-http documentation?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure honestly, I'm not sure it belongs in graphql-js even 😅

@benjie benjie merged commit 4c8343e into graphql:source Jan 18, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants