Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GraphQL-js documentation should be deleted once new graphql-js.org redirects have proved stable #1943

Open
benjie opened this issue Jan 18, 2025 · 5 comments

Comments

@benjie
Copy link
Member

benjie commented Jan 18, 2025

I think we can just delete this folder? https://github.com/graphql/graphql.github.io/tree/source/src/pages/graphql-js

The redirects were handled by #1798

@saihaj
Copy link
Member

saihaj commented Jan 20, 2025

@JoviDeCroock thoughts?

@JoviDeCroock
Copy link
Member

I agree 😅

@benjie
Copy link
Member Author

benjie commented Jan 23, 2025

I think this is good to go now. Ideally someone would go through each of the existing /graphql-js/* pages and check they redirect to a sensible place, but... 🤷‍♂

@benjie
Copy link
Member Author

benjie commented Jan 23, 2025

#1945

@benjie
Copy link
Member Author

benjie commented Jan 23, 2025

Deleting the folder seems to be insufficient; certain links do not function now - e.g. "GraphQL.JS Tutorial" in the header. It's possible all the relative links to /graphql-js will not work too? That said... the "GraphQL.js" one in the FAQ seems to work. https://graphql-github-io-git-delete-gra-0df139-the-graph-ql-foundation.vercel.app/faq/getting-started/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants