Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PYIC-7904: routing for reverification journey #2876

Merged
merged 4 commits into from
Jan 17, 2025
Merged

PYIC-7904: routing for reverification journey #2876

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c3094cc
PYIC-7904: update reverification journey with new pages
thebauSoftwire Jan 15, 2025
2b40d27
PYIC-7904: update api tests
thebauSoftwire Jan 15, 2025
c7a5bd8
PYIC-7904: fix failing api test
thebauSoftwire Jan 15, 2025
e31b806
PYIC-7904: use INELIGIBLE_SKIP_MESSAGE and fix failing api tests
thebauSoftwire Jan 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion api-tests/features/dl-auth-source-checks/dl-auth-source-checks.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,8 +202,9 @@ Feature: Authoritative source checks with driving licence CRI
| address | kenneth-current |
| fraud | kenneth-score-2 |
When I start a new 'reverification' journey
Then I get a 'you-can-change-security-code-method' page response
When I submit a 'next' event
Then I get a 'page-ipv-identity-document-start' page response
Given I activate the 'drivingLicenceAuthCheck' feature set
When I submit an 'appTriage' event
Then I get a 'dcmaw' CRI response
When I submit 'kenneth-driving-permit-valid' details to the CRI stub
Expand Down
42 changes: 34 additions & 8 deletions api-tests/features/mfa-reset-journey.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,19 +10,25 @@ Feature: MFA reset journey

# Start MFA reset journey
When I start a new 'reverification' journey
Then I get a 'page-ipv-identity-document-start' page response
Then I get a 'you-can-change-security-code-method' page response

Scenario: Successful MFA reset journey
When I submit a 'next' event
Then I get a 'page-ipv-identity-document-start' page response
When I submit an 'appTriage' event
Then I get a 'dcmaw' CRI response
When I submit 'kenneth-driving-permit-valid' details to the CRI stub
When I submit 'kenneth-passport-valid' details to the CRI stub
Comment on lines -18 to +20
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when we turn on dl auth source checks this test will fail so figured I'd update it now

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

Then I get a 'page-dcmaw-success' page response
When I submit a 'next' event
Then I get a 'we-matched-you-to-your-one-login' page response
When I submit a 'next' event
Then I get an OAuth response
When I use the OAuth response to get my MFA reset result
Then I get a successful MFA reset result

Scenario: Failed MFA reset journey with breaching CI - user can still reuse existing identity
When I submit a 'next' event
Then I get a 'page-ipv-identity-document-start' page response
When I submit an 'appTriage' event
Then I get a 'dcmaw' CRI response
When I submit 'kenneth-passport-with-breaching-ci' details to the CRI stub
Expand All @@ -37,23 +43,24 @@ Feature: MFA reset journey
Then I get a 'page-ipv-reuse' page response

Scenario: Failed MFA reset journey - DCMAW error
When I submit a 'next' event
Then I get a 'page-ipv-identity-document-start' page response
When I submit an 'appTriage' event
Then I get a 'dcmaw' CRI response
When I call the CRI stub and get an 'access-denied' OAuth error
When I submit a 'next' event
When I call the CRI stub and get an 'access_denied' OAuth error
Then I get an OAuth response
When I use the OAuth response to get my MFA reset result
Then I get an unsuccessful MFA reset result with failure code 'identity_check_incomplete'

Scenario: Failed MFA reset journey - no photo id
When I submit an 'end' event
Then I get a 'pyi-another-way' page response
When I submit an 'next' event
Scenario: Failed MFA reset journey - find another way to access One Login
When I submit an 'cannot-change-security-codes' event
Then I get an OAuth response
When I use the OAuth response to get my MFA reset result
Then I get an unsuccessful MFA reset result with failure code 'identity_check_incomplete'

Scenario: Failed MFA reset journey - failed verification score
When I submit a 'next' event
Then I get a 'page-ipv-identity-document-start' page response
When I submit an 'appTriage' event
Then I get a 'dcmaw' CRI response
When I submit 'kenneth-passport-verification-zero' details to the CRI stub
Expand All @@ -64,6 +71,8 @@ Feature: MFA reset journey
Then I get an unsuccessful MFA reset result with failure code 'identity_check_failed'

Scenario: Failed MFA reset journey - non-matching identity
When I submit a 'next' event
Then I get a 'page-ipv-identity-document-start' page response
When I submit an 'appTriage' event
Then I get a 'dcmaw' CRI response
When I submit 'alice-passport-valid' details to the CRI stub
Expand All @@ -75,6 +84,23 @@ Feature: MFA reset journey
When I use the OAuth response to get my MFA reset result
Then I get an unsuccessful MFA reset result with failure code 'identity_did_not_match'

Scenario: Failed MFA reset journey - failed DL auth source check
Given I activate the 'drivingLicenceAuthCheck' feature set
When I submit a 'next' event
Then I get a 'page-ipv-identity-document-start' page response
When I submit an 'appTriage' event
Then I get a 'dcmaw' CRI response
When I submit 'kenneth-driving-permit-valid' details to the CRI stub
Then I get a 'drivingLicence' CRI response
When I submit 'kenneth-driving-permit-needs-alternate-doc' details with attributes to the CRI stub
| Attribute | Values |
| context | "check_details" |
Then I get a 'pyi-no-match' page response
When I submit a 'next' event
Then I get an OAuth response
When I use the OAuth response to get my MFA reset result
Then I get an unsuccessful MFA reset result with failure code 'identity_check_failed'

Rule: The user has no existing identity
Scenario: Attempted MFA reset journey
When I start a new 'reverification' journey
Expand Down
34 changes: 27 additions & 7 deletions ...as/process-journey-event/src/main/resources/statemachine/journey-maps/reverification.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,13 +85,25 @@ states:
lambda: check-reverification-identity
events:
found:
targetState: IDENTITY_START_PAGE
targetState: YOU_CAN_CHOOSE_HOW_YOU_GET_SECURITY_CODES_PAGE
not-found:
targetState: CRI_TICF
targetJourney: INELIGIBLE
targetState: INELIGIBLE_SKIP_MESSAGE
error:
targetJourney: TECHNICAL_ERROR
targetState: ERROR

YOU_CAN_CHOOSE_HOW_YOU_GET_SECURITY_CODES_PAGE:
response:
type: page
pageId: you-can-change-security-code-method
events:
next:
targetState: IDENTITY_START_PAGE
cannot-change-security-codes:
targetJourney: INELIGIBLE
targetState: INELIGIBLE_SKIP_MESSAGE

IDENTITY_START_PAGE:
response:
type: page
Expand All @@ -108,7 +120,7 @@ states:
targetState: ERROR
end:
targetJourney: INELIGIBLE
targetState: INELIGIBLE
targetState: INELIGIBLE_SKIP_MESSAGE

STRATEGIC_APP_TRIAGE:
nestedJourney: STRATEGIC_APP_TRIAGE
Expand All @@ -120,7 +132,7 @@ states:
targetState: ERROR
anotherWay:
targetJourney: INELIGIBLE
targetState: INELIGIBLE
targetState: INELIGIBLE_SKIP_MESSAGE
returnToRp:
targetState: RETURN_TO_RP

Expand All @@ -134,13 +146,13 @@ states:
targetState: POST_DCMAW_SUCCESS_PAGE
not-found:
targetJourney: INELIGIBLE
targetState: INELIGIBLE
targetState: INELIGIBLE_SKIP_MESSAGE
access-denied:
targetJourney: INELIGIBLE
targetState: INELIGIBLE
targetState: INELIGIBLE_SKIP_MESSAGE
temporarily-unavailable:
targetJourney: INELIGIBLE
targetState: INELIGIBLE
targetState: INELIGIBLE_SKIP_MESSAGE
dl-auth-source-check:
targetState: CRI_DRIVING_LICENCE_AUTH_SOURCE_CHECK

Expand Down Expand Up @@ -183,6 +195,14 @@ states:
type: process
lambda: call-ticf-cri
parent: CRI_TICF_STATE
events:
next:
targetState: WE_MATCHED_YOU_TO_YOUR_ONE_LOGIN_PAGE

WE_MATCHED_YOU_TO_YOUR_ONE_LOGIN_PAGE:
response:
type: page
pageId: we-matched-you-to-your-one-login
events:
next:
targetState: RETURN_TO_RP
Expand Down
Loading