Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PYIC-7904: routing for reverification journey #2876

Merged
merged 4 commits into from
Jan 17, 2025

Conversation

thebauSoftwire
Copy link
Contributor

@thebauSoftwire thebauSoftwire commented Jan 15, 2025

Proposed changes

What changed

  • added routing to reverification journey to use new pages
  • updated api tests

Why did it change

We've added new pages to be added for the reverification journey to better match the expected flow

Issue tracking

When I submit 'kenneth-driving-permit-valid' details to the CRI stub
When I submit 'kenneth-passport-valid' details to the CRI stub
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when we turn on dl auth source checks this test will fail so figured I'd update it now

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@thebauSoftwire thebauSoftwire marked this pull request as ready for review January 15, 2025 16:12
@thebauSoftwire thebauSoftwire requested review from a team as code owners January 15, 2025 16:12
@thebauSoftwire thebauSoftwire force-pushed the pyic-7904-reverify-journey branch from 76b429f to 2b40d27 Compare January 15, 2025 16:38
Copy link
Contributor

@Joe-Edwards-GDS Joe-Edwards-GDS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assume you're looking into the API tests, but a couple of other comments...

When I submit 'kenneth-driving-permit-valid' details to the CRI stub
When I submit 'kenneth-passport-valid' details to the CRI stub
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

Copy link
Contributor

@Joe-Edwards-GDS Joe-Edwards-GDS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@thebauSoftwire thebauSoftwire merged commit 8e1b4e7 into main Jan 17, 2025
7 checks passed
@thebauSoftwire thebauSoftwire deleted the pyic-7904-reverify-journey branch January 17, 2025 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants