Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aut-2844 : add new contact form problem with national insurance number #1651

Merged
merged 2 commits into from
May 31, 2024

Conversation

di-fabs
Copy link
Contributor

@di-fabs di-fabs commented May 30, 2024

What

Create new form “A problem with your national insurance number” (with English / Welsh variants and appropriate error states) and link to previous user selection

How to review

Go to http://localhost:3000/contact-us-questions?theme=proving_identity&subtheme=proving_identity_problem_with_national_insurance_number&lng=en&referer=

And play with the new form.

Checklist

  • Performance analyst has been notified of the change.
  • A UCD review has been performed.
  • Documentation has been updated to reflect these changes.

Related PRs

@di-fabs di-fabs requested review from a team as code owners May 30, 2024 08:16
@dbes-gds dbes-gds force-pushed the aut-2844-add-new-contact-form-national-number branch from 7b4f5b5 to e7819fd Compare May 31, 2024 12:56
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
50.0% Coverage on New Code (required ≥ 80%)
19.5% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@dbes-gds dbes-gds merged commit 4623abd into main May 31, 2024
4 of 5 checks passed
@dbes-gds dbes-gds deleted the aut-2844-add-new-contact-form-national-number branch May 31, 2024 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants