Bau: Remove ip from service calls #1640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BeckaL
force-pushed
the
BAU/remove-ip-from-service-calls
branch
3 times, most recently
from
eb325ec to
fe3bd05
Compare
BeckaL
changed the title
This is no longer required to set the ip in headers, since the common headers library that is now used gets this from the request that we now pass through.
This is no longer required to set the ip in headers, since the common headers library that is now used gets this from the request that we now pass through.
This is no longer required to set the ip in headers, since the common headers library that is now used gets this from the request that we now pass through.
This is no longer required to set the ip in headers, since the common headers library that is now used gets this from the request that we now pass through. Also pulls out some common noisy setup from these tests
…h to send notification service Hopefully this makes it a bit more obvious what the point of these tests are
This is no longer required to set the ip in headers, since the common headers library that is now used gets this from the request that we now pass through.
This is no longer required to set the ip in headers, since the common headers library that is now used gets this from the request that we now pass through.
This is no longer required to set the ip in headers, since the common headers library that is now used gets this from the request that we now pass through.
This is no longer required to set the ip in headers, since the common headers library that is now used gets this from the request that we now pass through.
This is no longer required to set the ip in headers, since the common headers library that is now used gets this from the request that we now pass through.
This is no longer required to set the ip in headers, since the common headers library that is now used gets this from the request that we now pass through.
This is no longer required to set the ip in headers, since the common headers library that is now used gets this from the request that we now pass through.
This is no longer required to set the ip in headers, since the common headers library that is now used gets this from the request that we now pass through.
This is no longer required to set the ip in headers, since the common headers library that is now used gets this from the request that we now pass through.
This is no longer required to set the ip in headers, since the common headers library that is now used gets this from the request that we now pass through.
This makes the naming consistent with the naming of the file it tests, meaning that it can be picked up by IDEs when looking for tests for a file
This is no longer required to set the ip in headers, since the common headers library that is now used gets this from the request that we now pass through.
This is no longer used since we switched to using the common headers library to set the x-forwarded-for header on requests to the backend, so can be removed
Uses common test data to avoid a bit of noisy setup
BeckaL
force-pushed
the
BAU/remove-ip-from-service-calls
branch
from
2564902 to
fe27c11
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Removes sourceIp as a parameter from all remaining services (some have already been done as part of AUT-2578).
This was previously being used to set the "x-forwarded-for" header on the requests we send to the backend, but the common headers library is now being used to set this header, which requires the whole request object to be passed through, which we have already done here.
Therefore these services can be tidied by removing this parameter, and also removing it from the overall options.
This PR also contains some minor tidies that I came across along the way.
How to review