BAU: Remove source ip from mfa service

This is no longer required to set the ip in headers, since the common headers library that is now used gets this from the request that we now pass through.
govuk-one-login · May 22, 2024 · eb325ec · eb325ec
1 parent 26f0f9a
commit eb325ec
Show file tree

Hide file tree

Showing 9 changed files with 1 addition and 11 deletions.
diff --git a/src/components/common/mfa/mfa-service.ts b/src/components/common/mfa/mfa-service.ts
@@ -18,7 +18,6 @@ export function mfaService(axios: Http = http): MfaServiceInterface {
     sessionId: string,
     clientSessionId: string,
     emailAddress: string,
-    sourceIp: string,
     persistentSessionId: string,
     isResendCodeRequest: boolean,
     userLanguage: string,
@@ -36,7 +35,6 @@ export function mfaService(axios: Http = http): MfaServiceInterface {
         {
           sessionId: sessionId,
           clientSessionId: clientSessionId,
-          sourceIp: sourceIp,
           persistentSessionId: persistentSessionId,
           userLanguage: userLanguage,
         },

diff --git a/src/components/common/mfa/send-mfa-controller.ts b/src/components/common/mfa/send-mfa-controller.ts
@@ -21,7 +21,6 @@ export function sendMfaGeneric(
       sessionId,
       clientSessionId,
       email,
-      req.ip,
       persistentSessionId,
       isResendCodeRequest,
       xss(req.cookies.lng as string),

diff --git a/src/components/common/mfa/tests/mfa-service.test.ts b/src/components/common/mfa/tests/mfa-service.test.ts
@@ -35,7 +35,7 @@ describe("mfa service", () => {
   });
 
   it("successfully calls the API to make a request to send an mfa code", async () => {
-    const { email, sessionId, clientSessionId, ip, diPersistentSessionId } =
+    const { email, sessionId, clientSessionId, diPersistentSessionId } =
       commonVariables;
     const req = createMockRequest(PATH_NAMES.ENTER_MFA, {
       headers: requestHeadersWithIpAndAuditEncoded,
@@ -63,7 +63,6 @@ describe("mfa service", () => {
       sessionId,
       clientSessionId,
       email,
-      ip,
       diPersistentSessionId,
       isResendCodeRequest,
       userLanguage,

diff --git a/src/components/common/mfa/tests/send-mfa-controller.test.ts b/src/components/common/mfa/tests/send-mfa-controller.test.ts
@@ -62,7 +62,6 @@ describe("send mfa controller", () => {
         sinon.match.any,
         sinon.match.any,
         sinon.match.any,
-        sinon.match.any,
         JOURNEY_TYPE.REAUTHENTICATION
       );
     });

diff --git a/src/components/common/mfa/types.ts b/src/components/common/mfa/types.ts
@@ -7,7 +7,6 @@ export interface MfaServiceInterface {
     sessionId: string,
     clientSessionId: string,
     emailAddress: string,
-    sourceIp: string,
     persistentSessionId: string,
     isResendCodeRequest: boolean,
     userLanguage: string,

diff --git a/src/components/enter-password/enter-password-controller.ts b/src/components/enter-password/enter-password-controller.ts
@@ -201,7 +201,6 @@ export function enterPasswordPost(
         sessionId,
         clientSessionId,
         email,
-        req.ip,
         persistentSessionId,
         false,
         xss(req.cookies.lng as string),

diff --git a/src/components/enter-password/tests/enter-password-controller.test.ts b/src/components/enter-password/tests/enter-password-controller.test.ts
@@ -133,7 +133,6 @@ describe("enter password controller", () => {
           sinon.match.any,
           sinon.match.any,
           sinon.match.any,
-          sinon.match.any,
           JOURNEY_TYPE.REAUTHENTICATION
         );
       });

diff --git a/src/components/reset-password-2fa-sms/reset-password-2fa-sms-controller.ts b/src/components/reset-password-2fa-sms/reset-password-2fa-sms-controller.ts
@@ -60,7 +60,6 @@ export function resetPassword2FASmsGet(
       sessionId,
       clientSessionId,
       email,
-      req.ip,
       persistentSessionId,
       false,
       xss(req.cookies.lng as string),

diff --git a/src/components/reset-password/reset-password-controller.ts b/src/components/reset-password/reset-password-controller.ts
@@ -132,7 +132,6 @@ export function resetPasswordPost(
         sessionId,
         clientSessionId,
         email,
-        req.ip,
         persistentSessionId,
         false,
         xss(req.cookies.lng as string),