Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require all marker fields to be listed in the schema #5302

Open
mstange opened this issue Jan 10, 2025 · 1 comment
Open

Require all marker fields to be listed in the schema #5302

mstange opened this issue Jan 10, 2025 · 1 comment
Labels
markers Anything to do with marker data structures, marker chart, or the marker table meta

Comments

@mstange
Copy link
Contributor

mstange commented Jan 10, 2025

At the moment, markers can have fields in their data object without listing all fields in the marker schema. This only works because the current storage format is just a JSON object, where each value has a key.
If we were to move to a format where we don't store the key for every field value for every marker, we need to first ensure that we don't have useful values stored in undeclared fields.

This is the tracking issue for that effort. We'll need to migrate all existing markers with undeclared fields via upgraders and via code paths in profile processing.

This bug can be resolved once all useful fields are declared in marker schemas, and once we can discard marker values for undeclared fields without anybody noticing.

┆Issue is synchronized with this Jira Task

@mstange
Copy link
Contributor Author

mstange commented Jan 10, 2025

#5281 has a list of cases of undeclared fields that we'll need to work through.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
markers Anything to do with marker data structures, marker chart, or the marker table meta
Projects
None yet
Development

No branches or pull requests

2 participants