Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Declare IPC marker fields in the schema #5306

Open
mstange opened this issue Jan 10, 2025 · 0 comments
Open

Declare IPC marker fields in the schema #5306

mstange opened this issue Jan 10, 2025 · 0 comments
Labels
markers Anything to do with marker data structures, marker chart, or the marker table profile data Issues related to the profile format, data structure, or profile upgraders

Comments

@mstange
Copy link
Contributor

mstange commented Jan 10, 2025

IPC markers currently don't have a schema, or if they do, it's a broken schema from an upgrader.

We need to add a schema and declare all the IPC marker fields in it, for #5302.

We can probably keep all the custom handling of IPC markers for now, i.e. any code which does things based on data.type and which expects certain fields to be present based on the type. We just need to make it so that the fields don't get discarded if we change how marker fields are stored in the processed format.

We currently add an IPC marker schema when computing the derived profile data in selectors. This schema describes the synthesized IPC markers we create when processing the raw markers. We should rename this schema to DerivedIPC so that it doesn't conflict with the new IPC schema that''ll be stored in the profile.

┆Issue is synchronized with this Jira Task

@canova canova added profile data Issues related to the profile format, data structure, or profile upgraders markers Anything to do with marker data structures, marker chart, or the marker table labels Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
markers Anything to do with marker data structures, marker chart, or the marker table profile data Issues related to the profile format, data structure, or profile upgraders
Projects
None yet
Development

No branches or pull requests

2 participants