Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make various GC markers schema-based #5305

Open
mstange opened this issue Jan 10, 2025 · 0 comments
Open

Make various GC markers schema-based #5305

mstange opened this issue Jan 10, 2025 · 0 comments
Labels
markers Anything to do with marker data structures, marker chart, or the marker table memory

Comments

@mstange
Copy link
Contributor

mstange commented Jan 10, 2025

Markers with types GCSlice, GCMinor and GCMajor currently have custom code for their tooltips. Their fields timings / nursery / nurseryTimings are not declared in a schema.

We should add marker field formats for these JSON objects and declare the fields in the schema, for #5302.

So then the custom tooltip code would still be there, but it would just be called for a field whose format is e.g. gc-minor-nursery-timings, rather than for a marker whose data.type is GCMinor.

┆Issue is synchronized with this Jira Task

@canova canova added markers Anything to do with marker data structures, marker chart, or the marker table memory labels Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
markers Anything to do with marker data structures, marker chart, or the marker table memory
Projects
None yet
Development

No branches or pull requests

2 participants