-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use docker environment to build the actors reproducibly #865
Use docker environment to build the actors reproducibly #865
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #865 +/- ##
==========================================
+ Coverage 88.08% 88.10% +0.02%
==========================================
Files 95 95
Lines 19619 19628 +9
==========================================
+ Hits 17281 17294 +13
+ Misses 2338 2334 -4
|
Thanks for moving things into Makefile |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Out of an abundance of caution we shouldn't merge this until a few days after the upgrade has settled in case we're fighting fires and quickly releasing things. Once that window has passed -- say this friday this looks good to merge.
582587e
to
ff5db68
Compare
Just rebased onto filecoin-project/master to bring this PR up to date with recent changes. I think the upgrade from last week has settled enough we should be good to merge this now? |
Hey! 👋 As part of our cleanup to kick off the year, I'm reviewing all open non-draft pull requests. Could you please do one of the following for your PR? 1. Close it: If it's no longer needed. If there's no response in a week, I'll assume it's option 1 and close the PR. If you have any questions, just let me know. Thanks for your help in keeping things organized, and I appreciate your contributions! |
Hi @rjan90 this was ready for review two years ago, not sure if it's still needed or what needs to be updated to merge it |
It's probably far enough out of date at this point it should be closed, but I don't know if the original issue this PR and the previous PR were trying to address has been fixed some other way. |
Yeah, I´m uncertain if it is still needed. But I agree with you that it is probably best to:
|
I didn't have permissions to push to the original branch in #634, so I made my own fork.