Use docker environment to build the actors reproducibly #1606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We should try to use the exact image from dockerhub. This means updating rust will require two steps, but that's not a huge deal IMO.
This lets us take advantage of docker layers.
|
We should get someone with a mac to reproduce this, then merge it before it gets out of date again. I've made a few changes:
|
This means it isn't possible to reproducibly build a dirty repo but... nobody wants to do that anyways. It does mean that the reproducible build won't be affected by other files in the tree.
Stebalien
force-pushed
the
id/reproducible-build
branch
from
b4d3f3a to
2e0f0e4
Compare
rvagg
reviewed
Jan 23, 2025
|
I have opinions! See #1607 I've tested that it runs on a mac but only on an arm machine so can't get the same output, I do have an x86 mac in the house but it's a bit of an annoyance to get it set up for this, and those are going extinct now anyway. I'm getting this when built using my branch, I think it should be the same as this one so here it is: |
|
I'm getting the same value. In terms of macos, maybe we should just add |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Third attempt at fixing #171. All work on this PR was done by @lemmih in #634 and @ianconsolata in #865.
This isn't perfect (see #171 (comment)) but it does make it possible for end-users to reproduce the bundles built in CI as long as they have an x86 machine.
fixes #171