Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GITHUB-46(template): PR creation template #56

Merged
merged 2 commits into from
Dec 23, 2021
Merged

GITHUB-46(template): PR creation template #56

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b61904c
chore: added GitHub PR template.
Krakazybik Dec 23, 2021
985abf6
chore: header size and rename checks.
Krakazybik Dec 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .github/workflows/pull_request_template.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
# Description
<!-- 1. Description of your PR -->
# References
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick: Давай тогда чтоб не было громоздко, да и чтоб было по канону - сделаем не h1, а h2 заголовки))
(или даже h3 лучше)

Copy link
Member Author

@Krakazybik Krakazybik Dec 23, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

H2
image
выбирай сам
H3
image

Copy link
Member Author

@Krakazybik Krakazybik Dec 23, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Мне лично с полосочками больше нравится, но то вкусовщина и на скорость вливания PR'a не влияет

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Можно h2

<!-- 2. References to issue, PR or discussions -->
# Checks
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick: Мб Checklist?

Copy link
Member Author

@Krakazybik Krakazybik Dec 23, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Можно и checkList , я пародировал ГХ =)
image

- [ ] Description added
- [ ] Self-reviewed
- [ ] CI pass