Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GITHUB-46(template): PR creation template #56

Merged
merged 2 commits into from
Dec 23, 2021

Conversation

Krakazybik
Copy link
Member

@Krakazybik Krakazybik commented Dec 23, 2021

Description

Added: GitHub PR creation template.

References

#46 (comment)

Checks

  • Description added
  • Self-reviewed
  • CI pass

@Krakazybik Krakazybik requested a review from azinit December 23, 2021 14:24
@Krakazybik Krakazybik self-assigned this Dec 23, 2021
@Krakazybik Krakazybik changed the title GITHUB(template): PR creation template GITHUB-46(template): PR creation template Dec 23, 2021
Comment on lines 1 to 3
# Description
<!-- 1. Description of your PR -->
# References
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick: Давай тогда чтоб не было громоздко, да и чтоб было по канону - сделаем не h1, а h2 заголовки))
(или даже h3 лучше)

Copy link
Member Author

@Krakazybik Krakazybik Dec 23, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

H2
image
выбирай сам
H3
image

Copy link
Member Author

@Krakazybik Krakazybik Dec 23, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Мне лично с полосочками больше нравится, но то вкусовщина и на скорость вливания PR'a не влияет

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Можно h2

<!-- 1. Description of your PR -->
# References
<!-- 2. References to issue, PR or discussions -->
# Checks
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick: Мб Checklist?

Copy link
Member Author

@Krakazybik Krakazybik Dec 23, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Можно и checkList , я пародировал ГХ =)
image

@Krakazybik Krakazybik merged commit 265b56a into master Dec 23, 2021
@Krakazybik Krakazybik deleted the chore/GITHUB-pr-template branch December 23, 2021 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants