Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(person-select): adding html attribute name for selectedPerson #1687

Merged
merged 1 commit into from
Dec 4, 2024
Merged

fix(person-select): adding html attribute name for selectedPerson #1687

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .changeset/empty-jars-attack.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
"@equinor/fusion-wc-person": patch
---

### Changes in `PersonSelectElement`

- Added the `attribute: 'selectedperson'` to the `selectedPerson` property config to fix use in react and as a legal html property name.
1 change: 1 addition & 0 deletions packages/person/src/components/select/element.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,6 +127,7 @@ export class PersonSelectElement
search = '';

@property({
attribute: 'selectedperson',
converter(value) {
/* converter to allow user to pass personobject as property */
if (value?.length) {
Expand Down
Loading