Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(person-select): adding html attribute name for selectedPerson #1687

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

eikeland
Copy link
Contributor

@eikeland eikeland commented Dec 4, 2024

Changes in PersonSelectElement

  • Added the attribute: 'selected-person' to the selectedPerson property config to fix use in react and as a legal html property name.

Copy link

changeset-bot bot commented Dec 4, 2024

🦋 Changeset detected

Latest commit: 971f74a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@equinor/fusion-wc-person Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@eikeland eikeland self-assigned this Dec 4, 2024
@eikeland eikeland marked this pull request as ready for review December 4, 2024 09:17
@eikeland eikeland force-pushed the fix/person/person-selected/selectedperson-attribute branch from 322f562 to 9ddb7d6 Compare December 4, 2024 09:22
@eikeland eikeland force-pushed the fix/person/person-selected/selectedperson-attribute branch from 9ddb7d6 to 971f74a Compare December 4, 2024 09:39
@eikeland eikeland merged commit 6bd2a51 into main Dec 4, 2024
6 of 8 checks passed
@eikeland eikeland deleted the fix/person/person-selected/selectedperson-attribute branch December 4, 2024 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants