Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to dotnet9 #1957

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Update to dotnet9 #1957

wants to merge 2 commits into from

Conversation

Eddasol
Copy link
Contributor

@Eddasol Eddasol commented Jan 16, 2025 •
edited
Loading

Closes #1906

Ready for review checklist:

  • A self-review has been performed
  • All commits run individually
  • Temporary changes have been removed, like console.log, TODO, etc.
  • The PR has been tested locally
  • A test have been written
    • This change doesn't need a new test
  • Relevant issues are linked
  • Remaining work is documented in issues
    • There is no remaining work from this PR that require new issues
  • The changes does not introduce dead code as unused imports, functions etc.

@Eddasol Eddasol marked this pull request as draft January 16, 2025 09:48
@Eddasol Eddasol force-pushed the dotnet9 branch 3 times, most recently from d852e9b to 34ad695 Compare January 16, 2025 11:56
@Eddasol Eddasol self-assigned this Jan 16, 2025
@Eddasol Eddasol added backend Backend related functionality improvement Improvement to existing functionality labels Jan 16, 2025
@github-actions GitHub Actions
Copy link

🔔 Changes in database folder detected 🔔
Do these changes require adding new migrations? 🤔 In that case follow these steps.
If you are uncertain, ask a database admin on the team 😄

@Eddasol Eddasol marked this pull request as ready for review January 16, 2025 13:14
oysand
oysand approved these changes Jan 17, 2025
View reviewed changes
Copy link
Contributor

@oysand oysand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Christdej
Christdej reviewed Jan 17, 2025
View reviewed changes
Copy link
Contributor

@Christdej Christdej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might have to wait until team updates to Ubuntu 22 or higher

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Christdej Christdej Christdej left review comments

@oysand oysand oysand approved these changes

Assignees

@Eddasol Eddasol

Labels
backend Backend related functionality improvement Improvement to existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade to dotnet 9
3 participants
@Eddasol @oysand @Christdej