Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove parameter database and depend on {epiparameterDB} #415

Merged
merged 17 commits into from
Nov 22, 2024
Merged

Conversation

joshwlambert
Copy link
Member

This PR splits the {epiparameter} code and data by removing the epidemiological parameter database from the package and instead depending on the new {epiparameterDB} package that stores and distributes the epiparameters that previously were in the {epiparameter} package.

Changes include:

  • remove parameter.json and data_dictionary.json
  • remove validate-json.yaml workflow
  • removing the CC0 data license from the LICENSE file
  • removing {jsonlite} as suggested dependency
  • remove sysdata
  • update functions that called sysdata to use .read_epiparameter_db()
  • update .read_epiparameter_db() to call epiparameterDB::epiparameterDB
  • remove .is_pkg_installed()
  • remove unit tests for functions that are removed
  • update dependency documentation in design_principles.Rmd vignette

Copy link

This pull request:

  • Adds 1 new dependencies (direct and indirect)
  • Adds 1 new system dependencies
  • Removes 0 existing dependencies (direct and indirect)
  • Removes 0 existing system dependencies

Reach out on slack (#code-review or #help channels) to double check if there are base R alternatives to the new dependencies.

(Note that results may be inaccurate if you branched from an outdated version of the target branch.)

Copy link

This pull request:

  • Adds 1 new dependencies (direct and indirect)
  • Adds 1 new system dependencies
  • Removes 0 existing dependencies (direct and indirect)
  • Removes 0 existing system dependencies

Reach out on slack (#code-review or #help channels) to double check if there are base R alternatives to the new dependencies.

(Note that results may be inaccurate if you branched from an outdated version of the target branch.)

@joshwlambert joshwlambert merged commit 5460de1 into main Nov 22, 2024
10 checks passed
@joshwlambert joshwlambert deleted the split-data branch November 22, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant