Cache DB on package loading #417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshwlambert
added
data management
internal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds data caching to the {epiparameter} package for library of epidemiological parameters (using {cachem}).
Since #415 the epiparameter database was being created (i.e. parameters calculated and
<epiparameter>objects created) each timeepiparameter_db()was called. This resurfaced a previous issue (#198) that was resolved in PR #207 by usingsysdata. However, since PR #415sysdatawas removed and instead the JSON library was loaded from {epiparameterDB}.NB: {epiparameter} cannot hold the library of parameters as it requires it's own data license and due to CRAN rules this requires being housed in its own package.
To resolve this issue with a new approach, this PR implements data caching of the database of parameters when the {epiparameter} package is loaded (using
.onLoad()). This should reduce the runtime ofepiparameter_db(), especially if called repeatedly.Note: data caching is not implement in
epidist_db()as it is deprecated and will be removed after the next version release.