update SIGKILL hint msg

[danmoseley]

re #97049 (comment)

[ghost]

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

Issue Details

---

re #97049 (comment)

Author:	danmoseley
Assignees:	-
Labels:	area-Infrastructure-libraries
Milestone:	-

[danmoseley]

Will need to update pattern in #97049 (comment) and any similar ones.

[carlossanlop]

Much more helpful.

[jkotas]

Thanks!

[danmoseley]

@carlossanlop is there a way I can tell it to merge if everything ends up green? I can do this in some other repos.

[carlossanlop]

You mean automerge? We would have to ask folks if anyone has an objection to reenabling it. I do not know why it was disabled but I'm sure there was a good reason. @ViktorHofer @ericstj @stephentoub @jkotas

[stephentoub]

You mean automerge? We would have to ask folks if anyone has an objection to reenabling it. I do not know why it was disabled but I'm sure there was a good reason. @ViktorHofer @ericstj @stephentoub @jkotas

If memory serves you need required legs in order to use that safely, and we don't have any right now because of the variations of what's run for different kinds of changes.

[danmoseley]

ah - yes.

[ViktorHofer]

If memory serves you need required legs in order to use that safely, and we don't have any right now because of the variations of what's run for different kinds of changes.

Exactly.

[danmoseley]

ironically it produced an example

===========================================================================================================
/private/tmp/helix/working/BE490A9E/w/A6C008DC/e /private/tmp/helix/working/BE490A9E/w/A6C008DC/e
  Discovering: System.Text.Json.Tests (method display = ClassAndMethod, method display options = None)
  Discovered:  System.Text.Json.Tests (found 7275 of 7334 test cases)
  Starting:    System.Text.Json.Tests (parallel test collections = on [6 threads], stop on fail = off)
./RunTests.sh: line 180: 50798 Killed: 9               "$RUNTIME_PATH/dotnet" exec --runtimeconfig System.Text.Json.Tests.runtimeconfig.json --depsfile System.Text.Json.Tests.deps.json xunit.console.dll System.Text.Json.Tests.dll -xml testResults.xml -nologo -nocolor -notrait category=IgnoreForCI -notrait category=OuterLoop -notrait category=failing $RSP_FILE
/private/tmp/helix/working/BE490A9E/w/A6C008DC/e
----- end Thu Jan 25 11:56:01 PST 2024 ----- exit code 137 ----------------------------------------------------------
exit code 137 means SIGKILL Killed either due to out of memory/resources (see /var/log/messages) or by explicit kill.
ulimit -c value: 0
Unable to obtain kernel buffer: Operation not permitted
usage: sudo dmesg
----- start =============== XUnitLogChecker Output =====================================================
No dumps found in /cores.
----- end =============== XUnitLogChecker Output - exit code 0 ===========================

[danmoseley]

With respect to /var/log/messages, ideally the dmesg call I added way back would show those, but it doesn't:

Unable to obtain kernel buffer: Operation not permitted
usage: sudo dmesg

https://github.com/danmoseley/runtime/blob/56758a0cc94735f1084278416e006e65329b8071/eng/testing/RunnerTemplate.sh#L231

Would changing to sudo dmesg here help? @jkoritzinsky will sudo work in this context?

edit: this is macOS. I don't have a mac, so I don't know what is required here.
Console log: 'System.Text.Json.Tests' from job c64278dc-2f1f-4ed3-befd-dbdb88d5f17a workitem a7243e3a-3e65-4a6b-9174-020e2f7b6064 (osx.1200.amd64.open) executed on machine dci-mac-build-330.local running macOS-12.7.2

[danmoseley]

or maybe @wfurt knows the answer to above.

[danmoseley]

who else is a mac person .. @jkoritzinsky ?

[jkoritzinsky]

I don't know how sudo permissions are set up on the Helix machines. dnceng should know.

[danmoseley]

@dotnet/dnceng anyone know ?

[jkotas]

If the regular CI jobs had machine admin access, I think it would be a security issue to fix.

[wfurt]

runing sudo in container or disposable VM is ok IMHO. But that would be problematic on Mac as we keep physical machine AFAIK. You can perhaps make the test conditional on privilege access @danmoseley so it can be at least executed locally.

Also we can ask@dotnet/dnceng to make dmesg SUID or try to use log show instead.

[danmoseley]

Sounds good to me but I don't think I can do this myself as I can't test locally. It is worth fixing though.