-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sudo to dmesg call in test run template #97624
Conversation
Tagging subscribers to this area: @dotnet/area-infrastructure-libraries Issue DetailsTesting on macOS per #97519 (comment) Ignore the first diff.
|
@@ -228,7 +230,7 @@ fi | |||
if [ -n "$HELIX_WORKITEM_PAYLOAD" ]; then | |||
# For abrupt failures, in Helix, dump some of the kernel log, in case there is a hint | |||
if [[ $test_exitcode -ne 1 ]]; then | |||
dmesg | tail -50 | |||
sudo dmesg | tail -50 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can read darwin logs without sudo with builtin log
utility. e.g. to get past five minutes kernel logs:
log show --debug --predicate 'process == "kernel"' --start "$(date -v -5M '+%Y-%m-%d %H:%M:%S')"
@am11 thanks for the suggestion - would you consider offering a PR, if you have a Mac? I can't test as I don't have one. |
@danmoseley, I'm on macOS and can try to switch to |
@am11 yes, I think that's just fine. thanks! |
Testing on macOS per #97519 (comment)
Ignore the first diff.