Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENGDOCS-1717 #18446
ENGDOCS-1717 #18446
Changes from 8 commits
9fa24cc
b1092f4
4150e96
680222b
e9f99f4
339ea11
61ee80a
23ee65f
6179e00
e9ae2c6
d9ee9e8
53734a0
ceee2e6
02f6108
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if this is an ideal heuristic for describing the
.syncignore
contents. There are some fairly significant semantic differences between.dockerignore
/.syncignore
and.gitignore
ignore syntaxes, so I wouldn't want users to copy/paste and expect it to work. Less importantly: the content ignored during the inner loop may not align entirely with what goes into.gitignore
. Maybe we could just add a caveat about the syntactic differences... I'm not sure the best way to approach it.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've adjusted this sentence to reflect your comment above. I actually think this is fine for now, we can revisit this post-EAP and monitor if users need extra clarification