ENGDOCS-1717 #18446
ENGDOCS-1717 #18446
Conversation
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| Some example of things you might want to add to your `.syncignore` file are: | ||
| - ? | ||
|
|
||
| In general, the contents of your `.syncignore` file should be similar to what you have in your `.gitignore` file. |
There was a problem hiding this comment.
I'm not sure if this is an ideal heuristic for describing the .syncignore contents. There are some fairly significant semantic differences between .dockerignore/.syncignore and .gitignore ignore syntaxes, so I wouldn't want users to copy/paste and expect it to work. Less importantly: the content ignored during the inner loop may not align entirely with what goes into .gitignore. Maybe we could just add a caveat about the syntactic differences... I'm not sure the best way to approach it.
There was a problem hiding this comment.
I've adjusted this sentence to reflect your comment above. I actually think this is fine for now, we can revisit this post-EAP and monitor if users need extra clarification
|
|
||
| - Upon launching Docker Desktop, it can take between 5-10 seconds for Synchronized file sharing to fully initialize. During this window, file share instances display as **Connecting** and any new containers created during this window won't replace bind mounts with Synchronized file sharing. | ||
|
|
||
| - `.syncignore` changes won't cause deletion until file share recreation. In other words, files that become ignored due to a modification to `.syncignore` are left in place, but no longer update through synchronization. |
There was a problem hiding this comment.
"..changes won't cause deletion.." Do we mean the files are not deleted? Wondering if we can rephrase it
There was a problem hiding this comment.
nit: Should we hyphenate re-creation for clarity
Proposed changes
Related issues (optional)