-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(ingest/tableau): add test for extract_project_hierarchy scenario #12079
Merged
hsheth2
merged 17 commits into
datahub-project:master
from
sid-acryl:_is_denied_project_test
Dec 20, 2024
Merged
test(ingest/tableau): add test for extract_project_hierarchy scenario #12079
hsheth2
merged 17 commits into
datahub-project:master
from
sid-acryl:_is_denied_project_test
Dec 20, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
ingestion
PR or Issue related to the ingestion of metadata
label
Dec 10, 2024
datahub-cyborg
bot
added
the
needs-review
Label for PRs that need review from a maintainer.
label
Dec 10, 2024
hsheth2
reviewed
Dec 10, 2024
metadata-ingestion/tests/integration/tableau/test_tableau_ingest.py
Outdated
Show resolved
Hide resolved
metadata-ingestion/tests/integration/tableau/test_tableau_ingest.py
Outdated
Show resolved
Hide resolved
datahub-cyborg
bot
added
pending-submitter-response
Issue/request has been reviewed but requires a response from the submitter
and removed
needs-review
Label for PRs that need review from a maintainer.
labels
Dec 10, 2024
datahub-cyborg
bot
added
needs-review
Label for PRs that need review from a maintainer.
and removed
pending-submitter-response
Issue/request has been reviewed but requires a response from the submitter
labels
Dec 11, 2024
hsheth2
approved these changes
Dec 11, 2024
hsheth2
reviewed
Dec 11, 2024
metadata-ingestion/tests/integration/tableau/test_tableau_ingest.py
Outdated
Show resolved
Hide resolved
hsheth2
changed the title
test(ingestion/tableau): add test for extract_project_hierarchy scenario
test(ingest/tableau): add test for extract_project_hierarchy scenario
Dec 11, 2024
datahub-cyborg
bot
added
pending-submitter-response
Issue/request has been reviewed but requires a response from the submitter
and removed
needs-review
Label for PRs that need review from a maintainer.
labels
Dec 11, 2024
datahub-cyborg
bot
added
needs-review
Label for PRs that need review from a maintainer.
and removed
pending-submitter-response
Issue/request has been reviewed but requires a response from the submitter
labels
Dec 13, 2024
@sid-acryl there's conflicts on this one - please take a look |
datahub-cyborg
bot
added
pending-submitter-response
Issue/request has been reviewed but requires a response from the submitter
and removed
needs-review
Label for PRs that need review from a maintainer.
labels
Dec 17, 2024
done |
datahub-cyborg
bot
added
needs-review
Label for PRs that need review from a maintainer.
and removed
pending-submitter-response
Issue/request has been reviewed but requires a response from the submitter
labels
Dec 18, 2024
sgomezvillamor
approved these changes
Dec 18, 2024
datahub-cyborg
bot
added
pending-submitter-merge
and removed
needs-review
Label for PRs that need review from a maintainer.
labels
Dec 18, 2024
Dagster plugin failures are unrelated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consider a scenario where a Tableau site contains four projects: A, B, C, and D, with the following hierarchical relationship:
The goal is to extract assets from project A and its children while explicitly denying the child project B.
If we rely solely on the
project_pattern.allowed()
method, project C's assets will not be ingested.This happens because project C is not explicitly included in the
allow
list, nor is it part of thedeny
list.However, since
extract_project_hierarchy
is enabled, project C should ideally be included in the ingestion process unless explicitly denied.To address this, the function explicitly checks the deny regex to ensure that project C’s assets are ingested if it is not specifically denied in the deny list. This approach ensures that the hierarchy is respected while adhering to the configured allow/deny rules.