-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ingest/tableau): project_path_pattern use in _is_denied_project #12010
fix(ingest/tableau): project_path_pattern use in _is_denied_project #12010
Conversation
metadata-ingestion/src/datahub/ingestion/source/tableau/tableau.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
overall this code still confuses me
why do we have both is_allowed_project and is_denied_project? why isn't one method sufficient here? also, ideally we'd just use AllowDenyPattern
's built-in methods instead of re-implementing a bunch of regex matching logic here
@hsheth2
I will create a separate PR to add test cases for this scenario. |
@sid-acryl let's create some unit tests for that scenario |
|
No description provided.