Skip to content

Commit

Permalink
Remove unused variables in Windows code
Browse files Browse the repository at this point in the history
Upstreaming internal changes required to enforce `-Wunused-variable`
and `-Wunused-result` on Windows.

Tested: ci
Change-Id: I98d9ba8eeebf4dd8520b4263f4a57039c28020ad
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/404840
Commit-Queue: Alexander Aprelev <[email protected]>
Reviewed-by: Alexander Aprelev <[email protected]>
Auto-Submit: Ivan Inozemtsev <[email protected]>
  • Loading branch information
iinozemtsev authored and Commit Queue committed Jan 16, 2025
1 parent afcfe1e commit 6880ea8
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 3 deletions.
2 changes: 1 addition & 1 deletion runtime/bin/eventhandler_win.cc
Original file line number Diff line number Diff line change
Expand Up @@ -852,7 +852,7 @@ intptr_t ClientSocket::disconnecting_ = 0;
#endif

void ClientSocket::Shutdown(int how) {
int rc = shutdown(socket(), how);
shutdown(socket(), how);
if (how == SD_RECEIVE) {
MarkClosedRead();
}
Expand Down
1 change: 0 additions & 1 deletion runtime/vm/native_symbol_win.cc
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,6 @@ const char* NativeSymbolResolver::LookupSymbolName(uword pc, uword* start) {
const intptr_t kMaxNameLength = 2048;
const intptr_t kSymbolInfoSize = sizeof(SYMBOL_INFO); // NOLINT.
static char buffer[kSymbolInfoSize + kMaxNameLength];
static char name_buffer[kMaxNameLength];
MutexLocker lock(lock_);
if (!running_) {
return nullptr;
Expand Down
1 change: 0 additions & 1 deletion runtime/vm/os_win.cc
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@ intptr_t OS::ProcessId() {
const int64_t kTimeEpoc = 116444736000000000LL;

static bool LocalTime(int64_t seconds_since_epoch, tm* tm_result) {
time_t seconds = static_cast<time_t>(seconds_since_epoch);
SYSTEMTIME systemTime;
union {
FILETIME fileTime;
Expand Down

0 comments on commit 6880ea8

Please sign in to comment.