Skip to content

Commit

Permalink
dart create: Stop progress before exiting with error
Browse files Browse the repository at this point in the history
Otherwise the progress gizmo just keeps spinning, and dartdev never exits.

Change-Id: I53aa04a214354f3a5b085fa9d7bb562131f8ab95
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/403990
Commit-Queue: Sigurd Meldgaard <[email protected]>
Reviewed-by: Alexander Thomas <[email protected]>
  • Loading branch information
sigurdm authored and Commit Queue committed Jan 16, 2025
1 parent f72b1ae commit afcfe1e
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion pkg/dartdev/lib/src/commands/create.dart
Original file line number Diff line number Diff line change
Expand Up @@ -130,9 +130,9 @@ class CreateCommand extends DartdevCommand {
}
},
);
if (exitCode != 0) return exitCode;
progress.finish(showTiming: true);
log.stdout(buffer.toString().trimRight());
if (exitCode != 0) return exitCode;
}

log.stdout('');
Expand Down

0 comments on commit afcfe1e

Please sign in to comment.