Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin network to dufour and improve CI builds #138

Merged
merged 1 commit into from
Jul 24, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 0 additions & 20 deletions .github/workflows/auto_check.yml

This file was deleted.

33 changes: 12 additions & 21 deletions .github/workflows/main.yml
Original file line number Diff line number Diff line change
@@ -1,31 +1,22 @@
name: "Main"
name: Build (experimental package)

on:
pull_request:
push:
paths-ignore:
- "README.md"
branches:
- develop

jobs:
build-test:
runs-on: ubuntu-latest
name: Build test
steps:
- uses: actions/checkout@v2
- run: |
npm install
npx @dappnode/dappnodesdk build --skip_save

release:
name: Release
build:
runs-on: ubuntu-latest
needs: build-test
steps:
- uses: actions/checkout@v2
- name: Publish
- uses: actions/checkout@v4
- name: Build and upload to IPFS
run: |
npm install
npx @dappnode/dappnodesdk publish patch --dappnode_team_preset
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
DEVELOPER_ADDRESS: "0x7305356ad936A06c4ea5DF45AD5E5C3ff9Db818E"
npx @dappnode/dappnodesdk build \
--provider "remote" \
--verbose | tee build.log

echo "DNP (DAppNode Package) built and uploaded" >> $GITHUB_STEP_SUMMARY
Copy link
Collaborator

@ausias-armesto ausias-armesto Jun 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice if you could improve the pipeline so it filters in the build.log the ipfs hash and then notifies the IPFS hash through Zulip or store it in a github environment variable

gh variable set LATEST_IPFS ${ipfs_hash}

And create a second workflow which would read that variable ${{ vars.LATEST_IPFS }} and would publish the ipfs hash in the dappnode store.

grep "ipfs" build.log >> $GITHUB_STEP_SUMMARY
26 changes: 26 additions & 0 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
name: Build (release package)

on:
push:
branches:
- main

jobs:
build:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- name: Build and publish to package repository
run: |
npm install
npx @dappnode/dappnodesdk publish patch \
--provider "remote" \
--upload_to "ipfs" \
--verbose \
--github_release | tee build.log

echo "DNP (DAppNode Package) built and uploaded" >> $GITHUB_STEP_SUMMARY
grep "ipfs" build.log >> $GITHUB_STEP_SUMMARY
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
DEVELOPER_ADDRESS: "0x7305356ad936A06c4ea5DF45AD5E5C3ff9Db818E"
8 changes: 4 additions & 4 deletions DEVELOPING.md
Original file line number Diff line number Diff line change
@@ -1,18 +1,18 @@
# Repository structure

There are two repositories:
There are three repositories:

- official: https://github.com/dappnode/DAppNodePackage-Hopr
- internal: https://github.com/hoprnet/DAppNodePackage-Hopr
- testnet: https://github.com/dappnode/DAppNodePackage-Hopr-Testnet

The `internal` is a fork of the `official` one.
The `internal` is a fork of the `official` one. The `testnet` repo is configured specifically to use our `rotsee` testnet

Tha development happens on the internal repository and it has two branches:

- `develop` which contains the edge version, not meant for publishing
- `main` which is supposed to be in-sync with the `main` branch on the `official` repo


PRs are only meant to be made from the `internal` repo's `main` branch to the `official` repo's `main` branch.

# Development process
Expand Down Expand Up @@ -69,4 +69,4 @@ When running with the [DMS package](http://my.dappnode/installer/dnp/dms.dnp.dap

- [http://prometheus.dms.dappnode:9090/targets](http://prometheus.dms.dappnode:9090/targets) lists Prometheus targets. Make sure the package's target is available

Automatic import of Prometheus targets is only available if `prometheusTargets` and automatic import of Grafana dashboards is only available if `grafanaDashboards` is present in the observed [package manifest](http://my.dappnode/package-manifest/hopr.public.dappnode.eth).
Automatic import of Prometheus targets is only available if `prometheusTargets` and automatic import of Grafana dashboards is only available if `grafanaDashboards` is present in the observed [package manifest](http://my.dappnode/package-manifest/hopr.public.dappnode.eth).
6 changes: 0 additions & 6 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,3 @@ This is the DAppNode package for HOPR. You can download this to install the HOPR
## Getting Started

To install HOPR follow the instructions [here.](https://docs.hoprnet.org/node/using-dappnode)

## Versions

Hopr Admin: v1.1.7

Hoprd: v2.1.0
1 change: 0 additions & 1 deletion docker-compose.yml
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@ services:
- "seccomp:unconfined"
environment:
RUST_LOG: info
HOPRD_NETWORK: dufour
HOPRD_CONFIGURATION_FILE_PATH: /app/hoprd.cfg.yaml
HOPRD_HOST: "127.0.0.1:9091"
HOPRD_SAFE_ADDRESS: 0x
Expand Down
1 change: 1 addition & 0 deletions hoprd.cfg.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ hopr:
chain:
announce: true
check_unrealized_balance: true
network: dufour
safe_module:
safe_transaction_service_provider: https://safe-transaction.prod.hoprtech.net/
transport:
Expand Down
10 changes: 0 additions & 10 deletions setup-wizard.yml
Original file line number Diff line number Diff line change
Expand Up @@ -43,16 +43,6 @@ fields:
pattern: "^http[s]{0,1}://[a-z0-9.-]{3,}(:[0-9]{2,5})?(/[a-z0-9.-/_]+)?$"
patternErrorMessage: Must be a valid url starting with `http://` or `https://`

- id: HOPRD_NETWORK
target:
type: environment
name: HOPRD_NETWORK
service: node
title: HOPR network name
required: false
description: Optional HOPR network environment this HOPR node should use.
secret: false

# - id: IDENTITY
# target:
# type: fileUpload
Expand Down