Pin network to dufour and improve CI builds #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ausias-armesto
approved these changes
Jun 4, 2024
|
|
||
| echo "DNP (DAppNode Package) built and uploaded" >> $GITHUB_STEP_SUMMARY |
There was a problem hiding this comment.
It would be nice if you could improve the pipeline so it filters in the build.log the ipfs hash and then notifies the IPFS hash through Zulip or store it in a github environment variable
gh variable set LATEST_IPFS ${ipfs_hash}
And create a second workflow which would read that variable ${{ vars.LATEST_IPFS }} and would publish the ipfs hash in the dappnode store.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the network a static value in the provided configuration file.
Moreover, the CI workflows were improved to create packages on IPFS for each PR and
developbranch push.