Await early spans export + refactor handler wrapping #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhrebicek
reviewed
Sep 6, 2024
plugins/node/opentelemetry-instrumentation-aws-lambda/src/instrumentation.ts
Outdated
Show resolved
Hide resolved
zhrebicek
approved these changes
Sep 6, 2024
RafalSumislawski
merged commit 64fe3ce
into
coralogix-autoinstrumentation
10 of 15 checks passed
RafalSumislawski
deleted the
feature/NGSTN-982-await-early-spans-export
branch
kolov
approved these changes
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main goal is to wait for the
_sendEarlySpansto complete before we run the original handler function, because that function may occupy event loop for long enough to cause a timeout of_sendEarlySpansif they run concurrently. Additionally this PR refactors the code responsible for wrapping the heandler to make this simpler and also make that awaiting possible. It's not trully a refactor as in addition to making the code simpler it also solves some problems with edge-cases.