Remove handling of promises + fix issues connecting unrelated traces #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhrebicek
approved these changes
Sep 6, 2024
RafalSumislawski
merged commit fddc4e0
into
coralogix-nodejs-autoinstrumentation
1 of 3 checks passed
RafalSumislawski
deleted the
feature/NGSTN-982-remove-handling-of-promises
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't need to handle promises here because coralogix/opentelemetry-js-contrib#19 will convert promise based handlers to callback based.
The change to use ROOT_CONTEXT basically means that when we don't receive any trace information in the request, then we start a new trace. The previous code would in some edge cases reuse leftover trace context from previous invocation which doesn't make sense.