Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: ♻️ query function accepts queryObj #110

Merged
merged 2 commits into from
Jan 9, 2024

Conversation

nadeem-cs
Copy link
Contributor

Query function earlier had another query function to accept query Object.
Refactored it to base query function.

Copy link
Member

@ishaileshmishra ishaileshmishra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the credentials exposed in the test files

Copy link
Member

@ishaileshmishra ishaileshmishra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

thank you

@ishaileshmishra
Copy link
Member

Please check why Source Composition Analysis Scan / security (pull_request) is Failing

@nadeem-cs

@nadeem-cs
Copy link
Contributor Author

@ishaileshmishra The source compilation test is failing because of dependency issue with core library. I have already resolved it in the core package and sent for SRE. As soon as new version is released, we'll be good with this test.

@nadeem-cs nadeem-cs marked this pull request as ready for review January 9, 2024 12:12
@nadeem-cs nadeem-cs requested a review from a team as a code owner January 9, 2024 12:12
@nadeem-cs nadeem-cs merged commit b407e5c into v4-release Jan 9, 2024
5 of 6 checks passed
@nadeem-cs nadeem-cs deleted the fix/CS-43257-query-function branch January 9, 2024 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants