Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TS Delivery SDK v4 release #104

Closed
wants to merge 29 commits into from
Closed

TS Delivery SDK v4 release #104

wants to merge 29 commits into from

Conversation

nadeem-cs
Copy link
Contributor

Changes for JavaScript to Typescript

ishaileshmishra
ishaileshmishra suggested changes Jan 9, 2024
View reviewed changes
Copy link
Member

@ishaileshmishra ishaileshmishra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

found multiple credentials. Pls remove the credentials from the file @nadeem-cs

@nadeem-cs
Merge pull request #110 from contentstack/fix/CS-43257-query-function
b407e5c 
refactor: ♻️ query function accepts queryObj
@nadeem-cs nadeem-cs marked this pull request as ready for review January 9, 2024 12:16
@nadeem-cs nadeem-cs requested a review from a team as a code owner January 9, 2024 12:16
@nadeem-cs
Copy link
Contributor Author

nadeem-cs commented Jan 9, 2024 •
edited
Loading

@ishaileshmishra All the Uid key leaks are resolved in this PR.

ishaileshmishra
ishaileshmishra approved these changes Jan 11, 2024
View reviewed changes
Copy link
Member

@ishaileshmishra ishaileshmishra left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved.

  • Ensure that all tests pass before merging this PR, given its substantial size and scope
  • review failing checks

@abhinav-from-contentstack
fix: changed default export to named export
82ca954
@abhinav-from-contentstack
fix: added additionalData parameter to where
ec46e07
@abhinav-from-contentstack
fix: added unit tests
c57b1f0
@abhinav-from-contentstack
fix: added api test for taxonomies
05c979c
@abhinav-from-contentstack
fix: added ct query tests
4690f7d
@abhinav-from-contentstack
fix: separated taxonomy query operators
b57ff0f
@nadeem-cs
test: ✅ moves persistance test files
9ad9ae4
@nadeem-cs
test: ✅ adds plugin test in contentstack.spec.ts
3137697
@abhinav-from-contentstack
Merge pull request #117 from contentstack/feat/CS-42655-ts-taxonomy-test
6d625a4 
Feat/cs 42655 ts taxonomy test
@nadeem-cs
Merge branch 'v4-release' into chore/plugin-test
3d5108b
@nadeem-cs
fix: 🔥 removes redundant persistance test files
b8fcc92
@nadeem-cs
chore: updates LICENSE file
88ec73c
@nadeem-cs
chore: updates package-lock file
9140a6b
@nadeem-cs
Merge pull request #121 from contentstack/chore/plugin-test
421aae1 
chore: plugin test and other fixes
@nadeem-cs
fix: 🐛 getQuery function to return queryObj
ea00f31
@nadeem-cs
fix: 🐛 fetch function to directly give entry/asset/ct object
dc64b6f
@nadeem-cs
Merge pull request #123 from contentstack/chore/plugin-test
a931add 
Fixes: getQuery function and fetch functions
@nadeem-cs
Copy link
Contributor Author

Will be releasing the v4 version from v4-release branch and not from master. Hence closing this PR.

@nadeem-cs nadeem-cs closed this Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ishaileshmishra ishaileshmishra ishaileshmishra approved these changes

@sunil-lakshman sunil-lakshman Awaiting requested review from sunil-lakshman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nadeem-cs @ishaileshmishra @sunil-lakshman @abhinav-from-contentstack