Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
z3: add z3/4.8.7 recipe #1451
z3: add z3/4.8.7 recipe #1451
Changes from all commits
d87015b
4850103
cc92a49
7eb4f2f
df07354
62693c2
2bc47dd
4fce557
51c3420
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can fix this
package_info
usingcpp_info.filename
, it allows us to create different names for the file and the namespace.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea.
I find the way to create cmake imported targets in conan lacking though.
The current way to create a
namespace::target
inFindName.cmake
is limiting.How can I, in one
package_info
function call, createnamespace1::target1
inFindName1.cmake
AND createnamespace2::target2
inFindName2.cmake
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no way to create more than one
FindXXXX.cmake
file. If this is something needed/desirable, we need a feature in Conan.