-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
z3: add z3/4.8.7 recipe #1451
z3: add z3/4.8.7 recipe #1451
Conversation
Some configurations of 'z3/4.8.7' failed in build 1 (
|
Some configurations of 'z3/4.8.7' failed in build 2 (
|
@uilianries |
@madebr It's because we don't provide shared + runtime MT, because it's a configuration for static library only. You will need to filter it on this recipe using a conditional. |
Some configurations of 'z3/4.8.7' failed in build 3 (
|
Some configurations of 'z3/4.8.8' failed in build 4 (
|
Some configurations of 'z3/4.8.8' failed in build 5 (
|
All green in build 6 (
|
if not self.options.shared: | ||
if self.settings.os =="Linux": | ||
self.cpp_info.components["libz3"].system_libs.append("pthread") | ||
# FIXME: this generates a Z3::libz3 target instead of z3::libz3. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can fix this package_info
using cpp_info.filename
, it allows us to create different names for the file and the namespace.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea.
I find the way to create cmake imported targets in conan lacking though.
The current way to create a namespace::target
in FindName.cmake
is limiting.
def package_info(self):
self.cpp_info.names["cmake_find_package"] = "namespace"
self.cpp_info.components["comp"].names["cmake_find_package"] = "target"
self.cpp_info.components["comp"].filenames["cmake_find_package"] = "Name"
How can I, in one package_info
function call, create namespace1::target1
in FindName1.cmake
AND create namespace2::target2
in FindName2.cmake
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no way to create more than one FindXXXX.cmake
file. If this is something needed/desirable, we need a feature in Conan.
All green in build 7 (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be useful to use cmake_find_package[_multi]
generator in the test_package
to consume the libraries, so we check that the generated files have the proper casing.
…rted target Co-authored-by: Javier G. Sogo <[email protected]>
All green in build 8 (
|
Specify library name and version: z3/4.8.7
A shared mpir depenency is required because of wbhart/mpir#286
conan-center hook activated.