Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to set a robot's base (RCF) #762
Allow to set a robot's base (RCF) #762
Changes from 2 commits
b523e27
4d71696
a4a3e8f
c8819f4
ebd790b
5d63dc1
32addae
5aec18f
452c547
fa473ab
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe i haven't properly thought this through, but should this be
self.current_origin = self.current_origin @ self.origin.inverse() @ value
where i'm ignoring the distinction between a frame and its transformation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And similarly here, should we not 'remember' the transformations that have already been applied to the
current_axis
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand. Say you've got a robot with a proper base link. Then you set
robot.rfc = <some frame>
. This will change the origin of the base link. But if then you accessrobot.rcf
you'll get the identity transformation in return. Does that make sense? Is that supposed to make sense?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nope, the comment might be somewhat misleading if it's right above this line, but
Frame.worldXY()
is the default if theif
right after is not true. In the case where you set thercf
, then theif
goes in, and theref_frame
is that one instead.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think i didn't express myself well. consider the following code:
Without knowing the internals of
rcf
, that doesn't make any sense to the user.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're totally right. I'll fix.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be now fixed (a4a3e8f) along with simpler code path to determine what happens where (and a bit less duplication)