-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removal of StringCutObjectSelector from Muon trigger DQM #42437
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42437/36445
|
A new Pull Request was created by @caruta for master. It involves the following packages:
@nothingface0, @emanueleusai, @cmsbuild, @pmandrik, @syuvivida, @tjavaid, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
-1 Failed Tests: RelVals-INPUT RelVals-INPUTComparison SummarySummary:
|
+1 |
merge |
PR description:
This PR removes the "StringCutObjectSelector" from the Muon trigger DQM, with the aim of solving the memory issues faced during the 2022 rereco.
The cuts on the reco muons and trigger objects are now applied explicitly, since they are few and identical for all trigger paths.
This PR will be backported down to the 124X release (used for the 2022 rereco).
PR validation:
Tested running the DQM module on some of the latest RelVal, and checked the agreement of the distributions. Also ran
runTheMatrix.py -l limited -i all --ibeos
and no failures were seen.Changes in this PR have been already approved in 42348