Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removal of StringCutObjectSelector from Muon trigger DQM #42437

Merged
merged 1 commit into from
Aug 1, 2023

Conversation

caruta
Copy link
Contributor

@caruta caruta commented Aug 1, 2023

PR description:

This PR removes the "StringCutObjectSelector" from the Muon trigger DQM, with the aim of solving the memory issues faced during the 2022 rereco.
The cuts on the reco muons and trigger objects are now applied explicitly, since they are few and identical for all trigger paths.

  • Most of the changes are in HLTMuonMatchAndPlot.cc and in HLTMuonMatchAndPlot.h to implement the new way of applying cuts on the muon and trigger objects
  • The configuration files HLTMuonOfflineAnalyzer_cfi.py, HLTMuonOfflineAnalyzer_cff.py and HLTMuonOfflineAnalyzer_cosmics_cff.py have also been modified accordingly.

This PR will be backported down to the 124X release (used for the 2022 rereco).

PR validation:

Tested running the DQM module on some of the latest RelVal, and checked the agreement of the distributions. Also ran runTheMatrix.py -l limited -i all --ibeos and no failures were seen.

Changes in this PR have been already approved in 42348

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 1, 2023

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42437/36445

  • This PR adds an extra 24KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 1, 2023

A new Pull Request was created by @caruta for master.

It involves the following packages:

  • DQMOffline/Trigger (dqm)

@nothingface0, @emanueleusai, @cmsbuild, @pmandrik, @syuvivida, @tjavaid, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks.
@mtosi, @Fedespring, @missirol, @HuguesBrun, @jhgoh, @trocino, @cericeci, @rociovilar this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@perrotta
Copy link
Contributor

perrotta commented Aug 1, 2023

please test

@emanueleusai
Copy link
Member

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 1, 2023

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 1, 2023

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5b9310/34011/summary.html
COMMIT: 8f33991
CMSSW: CMSSW_13_3_X_2023-08-01-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/42437/34011/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

Comparison Summary

Summary:

  • You potentially removed 15 lines from the logs
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3150821
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3150796
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@perrotta
Copy link
Contributor

perrotta commented Aug 1, 2023

+1

@perrotta
Copy link
Contributor

perrotta commented Aug 1, 2023

merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants