Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12_4_X] Removal of StringCutObjectSelector from Muon trigger DQM #42465

Merged
merged 1 commit into from
Aug 7, 2023

Conversation

caruta
Copy link
Contributor

@caruta caruta commented Aug 3, 2023

PR description: Backport of #42437

This PR removes the "StringCutObjectSelector" from the Muon trigger DQM, with the aim of solving the memory issues faced during the 2022 rereco. The cuts on the reco muons and trigger objects are now applied explicitly, since they are few and identical for all trigger paths.

PR validation:

See master PR for validation description

Backport

Backport of #42437

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 3, 2023

A new Pull Request was created by @caruta for CMSSW_12_4_X.

It involves the following packages:

  • DQMOffline/Trigger (dqm)

@nothingface0, @emanueleusai, @cmsbuild, @pmandrik, @syuvivida, @tjavaid, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks.
@mtosi, @Fedespring, @missirol, @HuguesBrun, @jhgoh, @trocino, @cericeci, @rociovilar this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@VinInn
Copy link
Contributor

VinInn commented Aug 4, 2023

I run with 8 threads on the large production job that triggered the request of this PR (just 100 events)
I get

[innocent@patatrack02 tauCrash]$ grep RSS ori.log | cut -f 8 -d' ' | sort -n | head -n 1
8256.95
[innocent@patatrack02 tauCrash]$ grep RSS ori.log | cut -f 8 -d' ' | sort -n | tail -n 1
8598.48
[innocent@patatrack02 tauCrash]$ grep RSS fixed.log | cut -f 8 -d' ' | sort -n | head -n 1
7928.35
[innocent@patatrack02 tauCrash]$ grep RSS fixed.log | cut -f 8 -d' ' | sort -n | tail -n 1
8352.22

so a reduction of 250-300 MB that is not negligible at all.

@emanueleusai
Copy link
Member

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 6, 2023

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21bd9b/34108/summary.html
COMMIT: 2f005e0
CMSSW: CMSSW_12_4_X_2023-08-06-0000/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/42465/34108/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 5 lines to the logs
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 51
  • DQMHistoTests: Total histograms compared: 3766083
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3766059
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
  • Checked 212 log files, 167 edm output root files, 51 DQM output files
  • TriggerResults: no differences found

@emanueleusai
Copy link
Member

+1

  • DQM differences in MTD spurious

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 7, 2023

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

perrotta commented Aug 7, 2023

+1

@cmsbuild cmsbuild merged commit adb42c1 into cms-sw:CMSSW_12_4_X Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants