Add process readiness changed controller and event #3554
Conversation
|
is this waiting on any other PRs before we can merge? |
|
@sethboyles - All of the PRs are listed here. I just noticed one of them for the runtime schema is failing some checks. I will look into it. |
| @@ -15,6 +15,21 @@ class AppEventRepository | |||
| docker_credentials].freeze | |||
| SYSTEM_ACTOR_HASH = { guid: 'system', type: 'system', name: 'system', user_name: 'system' }.freeze | |||
|
|
|||
| def create_app_readiness_changed_event(app, readiness_changed_payload) | |||
There was a problem hiding this comment.
hey @ameowlia, where is this function being called, @sethboyles and i couldn't find it?
There was a problem hiding this comment.
My guess is that I forgot to delete that code. I initially (erroneously) added an app event instead of an app.process event. It's probably part of the app event that I should've deleted. I'll test to make sure everything still works if I remove it tomorrow. Good catch!
There was a problem hiding this comment.
I removed the code. Units still pass. And when I deployed it everything still works.
ameowlia
force-pushed
the
readiness-hc-events
branch
3 times, most recently
from
9f965d3 to
c216d2c
Compare
Co-authored-by: Geoff Franks <[email protected]> Signed-off-by: Geoff Franks <[email protected]>
ameowlia
force-pushed
the
readiness-hc-events
branch
from
c216d2c to
a563539
Compare
See more context here: cloudfoundry/capi-release#363
I have reviewed the contributing guide
I have viewed, signed, and submitted the Contributor License Agreement
I have made this pull request to the
mainbranchI have run all the unit tests using
bundle exec rakeI have run CF Acceptance Tests