Watch for readiness health check changes #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moleske
reviewed
Dec 19, 2023
| @@ -9,7 +9,7 @@ require ( | |||
| code.cloudfoundry.org/lager/v3 v3.0.3 | |||
| code.cloudfoundry.org/localip v0.0.0-20230406154046-f137f65d303d | |||
| code.cloudfoundry.org/locket v0.0.0-20230406154009-5e8522d975d2 | |||
| code.cloudfoundry.org/runtimeschema v0.0.0-20231212222654-3a68a52a50c2 | |||
| code.cloudfoundry.org/runtimeschema v0.0.0-20231214123546-c95bb31afd3e | |||
There was a problem hiding this comment.
note that we'll have to make sure that commit stays correct as that is the commit on the branch from which a pr was made. Not the master branch in runtimeschema. Reasons it could disappear is branch is deleted and the commit is squashed and merged rather than merged (squash and merge changes the commit sha)
|
@ameowlia looks like one of the introduced tests is failing: https://github.com/cloudfoundry/tps/actions/runs/7209350078/job/20321018944?pr=49#step:6:109 edit: oops, just saw you were aware of this in the comment: cloudfoundry/cloud_controller_ng#3554 (comment) |
|
oops! Fixed the test. |
ameowlia
force-pushed
the
readiness-hc
branch
from
fc654bc to
1c4f803
Compare
* bump bbs now with readiness information for app processes * update cc_client to have AppReadinessChanged function Signed-off-by: Geoff Franks <[email protected]> Co-authored-by: Geoff Franks <[email protected]> Signed-off-by: Amelia Downs <[email protected]> Co-authored-by: Amelia Downs <[email protected]>
ameowlia
force-pushed
the
readiness-hc
branch
from
1c4f803 to
eaf84cb
Compare
sethboyles
approved these changes
Jan 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See more context here: cloudfoundry/capi-release#363