Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update register-cloud-interactive.sh to support $NumCSP and $NumRegion #1410

Closed
wants to merge 1 commit into from
+14 −6
Closed

Update register-cloud-interactive.sh to support $NumCSP and $NumRegion #1410

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 14 additions & 6 deletions src/testclient/scripts/1.configureSpider/register-cloud-interactive.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ EOF
}

echo "####################################################################"
echo "## 1. Register Cloud Inforation"
echo "## 1. Register Cloud Information"
echo "####################################################################"

SCRIPT_DIR=`dirname ${BASH_SOURCE[0]-$0}`
Expand All @@ -155,11 +155,11 @@ echo -e " - Tumblebug Server : ${GREEN}${BOLD} $TumblebugServer ${NC}"
echo -e " - Spider Server : ${GREEN}${BOLD} $SpiderServer ${NC}"
echo ""

INDEXX=${TotalNumCSP}
INDEXX=${NumCSP}
echo -e "${BOLD}2) Enabled Clouds and Regions${NC}"

for ((cspi = 1; cspi <= INDEXX; cspi++)); do
INDEXY=${TotalNumRegion[$cspi]}
INDEXY=${NumRegion[$cspi]}
Comment on lines +158 to +162
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

register-cloud-interactive.sh 는 https://github.com/cloud-barista/cb-tumblebug/blob/main/scripts/initMultiCloudEnv.sh 를 통해서, 알려진 모든 CSP 및 리전을 등록하는 취지가 있으므로, 기존 값으로 유지하는 것이 좋을 것 같습니다.

  • 알려진 모든 CSP 및 리전을 등록해도 다른 스크립트 구동에 영향을 주지 않으며, 알려진 모든 CSP 및 리전을 등록하면 따로 테스트환경 파일을 명시할 필요가 없다는 장점이 있음.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@seokho-son
상기 PR은 register-cloud-interactive.sh의 용도를 잘못 파악하여 진행한 것으로 판단됩니다.
(register-cloud.sh를 사용하면 될 것으로 보입니다.--;)

CSP=${CSPType[$cspi]}
echo -e "${GREEN}${BOLD} - [$cspi] Cloud : $CSP (enabled regions : $INDEXY)${NC}"
for ((cspj = 1; cspj <= INDEXY; cspj++)); do
Expand Down Expand Up @@ -211,9 +211,17 @@ if [ "${INDEX}" == "0" ]; then

else
echo ""
CallSpiderPostDriver
CallSpiderPostRegion

INDEXX=${NumCSP}
for ((cspi = 1; cspi <= INDEXX; cspi++)); do
INDEXY=${NumRegion[$cspi]}
CSP=${CSPType[$cspi]}
CallSpiderPostDriver
for ((cspj = 1; cspj <= INDEXY; cspj++)); do
INDEX=$cspi
REGION=$cspj
CallSpiderPostRegion
done
done
fi

# Print list of all registered cloud info
Expand Down