Update register-cloud-interactive.sh to support $NumCSP and $NumRegion #1410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seokho-son
reviewed
Jan 10, 2024
There was a problem hiding this comment.
@sykim-etri 기여 감사합니다!
아래 사항만 처리해주시면 승인하도록 하겠습니다. :)
혹시 다른 필요성이 있다면 말씀해주시고요.
Comment on lines
+158
to
+162
| INDEXX=${NumCSP} | ||
| echo -e "${BOLD}2) Enabled Clouds and Regions${NC}" | ||
|
|
||
| for ((cspi = 1; cspi <= INDEXX; cspi++)); do | ||
| INDEXY=${TotalNumRegion[$cspi]} | ||
| INDEXY=${NumRegion[$cspi]} |
There was a problem hiding this comment.
register-cloud-interactive.sh 는 https://github.com/cloud-barista/cb-tumblebug/blob/main/scripts/initMultiCloudEnv.sh 를 통해서, 알려진 모든 CSP 및 리전을 등록하는 취지가 있으므로, 기존 값으로 유지하는 것이 좋을 것 같습니다.
- 알려진 모든 CSP 및 리전을 등록해도 다른 스크립트 구동에 영향을 주지 않으며, 알려진 모든 CSP 및 리전을 등록하면 따로 테스트환경 파일을 명시할 필요가 없다는 장점이 있음.
There was a problem hiding this comment.
@seokho-son
상기 PR은 register-cloud-interactive.sh의 용도를 잘못 파악하여 진행한 것으로 판단됩니다.
(register-cloud.sh를 사용하면 될 것으로 보입니다.--;)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
$TestSetFile에 지정된 $NumCSP, $NumRegion만큼 Cloud Driver와 Cloud Credential, Cloud Region와 Cloud Connection Config를 등록할 수 있도록 수정