Update society-of-biblical-literature-fullnote-bibliography.csl #5913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SBL style routinely wants a comma after an abbreviation-based citation (facilitated via annote) when the locator is sub-verbo. Other situations (sections, pages) sometimes (or often) don't include a comma.
|
Awesome! You just created a pull request to the Citation Styles Language styles repository. One of our human volunteers will try to get in touch soon (usually within a week). In the meantime, I will run some automated checks. You should be notified of the results in a few minutes. If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements. To update this pull request, visit the "Files changed" tab above, click on the ellipsis button in the top-right corner of your style, and then select "Edit file" to start editing:
If you have any questions, please leave a comment and we'll get back to you. While we usually respond in English, feel free to write in whatever language you're most comfortable. |
|
😃 Your submission passed all our automated tests. Below are some sample citations generated based on your proposed changes: society-of-biblical-literature-fullnote-bibliography.csl (modified style; unchanged output for sample items)Bob Hancké, Martin Rhodes, and Mark Thatcher, eds., Beyond Varieties of Capitalism: Conflict, Contradiction, and Complementarities in the European Economy (Oxford and New York: Oxford University Press, 2007); “CSL Search by Example,” Citation Style Editor, 2012, http://editor.citationstyles.org/searchByExample/. |
Adds a way to disambiguate electronic from print sources, which is necessary to be able to store DOIs for use by some styles but not output them for print sources in SBL style (since the style uses them only for electronic sources).
Adds a way to disambiguate electronic from print sources, which is necessary to be able to store DOIs for use by some styles but not output them for print sources in SBL style (since the style uses them only for electronic sources).
Adds a way to disambiguate electronic from print sources, which is necessary to be able to store DOIs for use by some styles but not output them for print sources in SBL style (since the style uses them only for electronic sources).
dstark
commented
Feb 18, 2022
|
😃 Your submission passed all our automated tests. Below are some sample citations generated based on your proposed changes: society-of-biblical-literature-fullnote-bibliography.csl (modified style; unchanged output for sample items)Bob Hancké, Martin Rhodes, and Mark Thatcher, eds., Beyond Varieties of Capitalism: Conflict, Contradiction, and Complementarities in the European Economy (Oxford and New York: Oxford University Press, 2007); “CSL Search by Example,” Citation Style Editor, 2012, http://editor.citationstyles.org/searchByExample/. |
2 similar comments
|
😃 Your submission passed all our automated tests. Below are some sample citations generated based on your proposed changes: society-of-biblical-literature-fullnote-bibliography.csl (modified style; unchanged output for sample items)Bob Hancké, Martin Rhodes, and Mark Thatcher, eds., Beyond Varieties of Capitalism: Conflict, Contradiction, and Complementarities in the European Economy (Oxford and New York: Oxford University Press, 2007); “CSL Search by Example,” Citation Style Editor, 2012, http://editor.citationstyles.org/searchByExample/. |
|
😃 Your submission passed all our automated tests. Below are some sample citations generated based on your proposed changes: society-of-biblical-literature-fullnote-bibliography.csl (modified style; unchanged output for sample items)Bob Hancké, Martin Rhodes, and Mark Thatcher, eds., Beyond Varieties of Capitalism: Conflict, Contradiction, and Complementarities in the European Economy (Oxford and New York: Oxford University Press, 2007); “CSL Search by Example,” Citation Style Editor, 2012, http://editor.citationstyles.org/searchByExample/. |
Omits a comma after the dictionary title or abbreviation in first references per SBLHS2.
dstark
commented
Mar 1, 2022
|
😃 Your submission passed all our automated tests. Below are some sample citations generated based on your proposed changes: society-of-biblical-literature-fullnote-bibliography.csl (modified style; unchanged output for sample items)Bob Hancké, Martin Rhodes, and Mark Thatcher, eds., Beyond Varieties of Capitalism: Conflict, Contradiction, and Complementarities in the European Economy (Oxford and New York: Oxford University Press, 2007); “CSL Search by Example,” Citation Style Editor, 2012, http://editor.citationstyles.org/searchByExample/. |
1) Adds support for introductions, prefaces, and forewords per SBLHS2 §6.2.14 via part-title. 2) Corrects support for conference papers per SBLHS2 §6.3.8.
1) Adds support for introductions, prefaces, and forewords per SBLHS2 §6.2.14 via part-title. 2) Corrects support for conference papers per SBLHS2 §6.3.8.
|
😃 Your submission passed all our automated tests. Below are some sample citations generated based on your proposed changes: society-of-biblical-literature-fullnote-bibliography.csl (modified style)Bob Hancké, Martin Rhodes, and Mark Thatcher, eds., Beyond Varieties of Capitalism: Conflict, Contradiction, and Complementarities in the European Economy (Oxford and New York: Oxford University Press, 2007); “CSL Search by Example,” Citation Style Editor, 2012, http://editor.citationstyles.org/searchByExample/. Bob Hancké, Martin Rhodes, and Mark Thatcher, eds., <i>Beyond Varieties of Capitalism: Conflict, Contradiction, and Complementarities in the European Economy</i> (Oxford and New York: Oxford University Press, 2007); “CSL Search by Example,” <i>Citation Style Editor</i>, 2012, http://editor.citationstyles.org/searchByExample/.<br/>
-Isabela Mares, “Firms and the Welfare State: When, Why, and How Does Social Policy Matter to Employers?,” in <i>Varieties of Capitalism. The Institutional Foundations of Comparative Advantage</i>, ed. Peter A. Hall and David Soskice (New York: Oxford University Press, 2001), 184–213; Martin Fenner et al., “A Data Citation Roadmap for Scholarly Data Repositories,” <i>Sci. Data</i> 6.1 (2019): 28, https://doi.org/10.1038/s41597-019-0031-8.<br/>
+Isabela Mares, “Firms and the Welfare State: When, Why, and How Does Social Policy Matter to Employers?,” in <i>Varieties of Capitalism. The Institutional Foundations of Comparative Advantage</i>, ed. Peter A. Hall and David Soskice (New York: Oxford University Press, 2001), 184–213; Martin Fenner et al., “A Data Citation Roadmap for Scholarly Data Repositories,” <i>Sci. Data</i> 6.1 (2019): 28, https://doi.org/10.1038/s41597-019-0031-8, http://www.nature.com/articles/s41597-019-0031-8.<br/>
<hr/>
-“CSL Search by Example.” <i>Citation Style Editor</i>, 2012. http://editor.citationstyles.org/searchByExample/.<br/>
-Fenner, Martin, Mercè Crosas, Jeffrey S. Grethe, David Kennedy, Henning Hermjakob, Phillippe Rocca-Serra, Gustavo Durand, Robin Berjon, Sebastian Karcher, et al. “A Data Citation Roadmap for Scholarly Data Repositories.” <i>Sci. Data</i> 6.1 (2019): 28. https://doi.org/10.1038/s41597-019-0031-8.<br/>
+“CSL Search by Example”<i>Citation Style Editor</i>, 2012. http://editor.citationstyles.org/searchByExample/.<br/>
+Fenner, Martin, Mercè Crosas, Jeffrey S. Grethe, David Kennedy, Henning Hermjakob, Phillippe Rocca-Serra, Gustavo Durand, Robin Berjon, Sebastian Karcher, et al. “A Data Citation Roadmap for Scholarly Data Repositories”<i>Sci. Data</i> 6.1 (2019): 28. https://doi.org/10.1038/s41597-019-0031-8, http://www.nature.com/articles/s41597-019-0031-8.<br/>
Hancké, Bob, Martin Rhodes, and Mark Thatcher, eds. <i>Beyond Varieties of Capitalism: Conflict, Contradiction, and Complementarities in the European Economy</i>. Oxford and New York: Oxford University Press, 2007.<br/>
-Mares, Isabela. “Firms and the Welfare State: When, Why, and How Does Social Policy Matter to Employers?” Pages 184–213 in <i>Varieties of Capitalism. The Institutional Foundations of Comparative Advantage</i>. Edited by Peter A. Hall and David Soskice. New York: Oxford University Press, 2001.<br/>
+Mares, Isabela. “Firms and the Welfare State: When, Why, and How Does Social Policy Matter to Employers?”Pages 184–213 in <i>Varieties of Capitalism. The Institutional Foundations of Comparative Advantage</i> Edited by Peter A. Hall and David Soskice. New York: Oxford University Press, 2001.<br/>
|
dstark
commented
Mar 15, 2022
|
😃 Your submission passed all our automated tests. Below are some sample citations generated based on your proposed changes: society-of-biblical-literature-fullnote-bibliography.csl (modified style)Bob Hancké, Martin Rhodes, and Mark Thatcher, eds., Beyond Varieties of Capitalism: Conflict, Contradiction, and Complementarities in the European Economy (Oxford and New York: Oxford University Press, 2007); “CSL Search by Example,” Citation Style Editor, 2012, http://editor.citationstyles.org/searchByExample/. Bob Hancké, Martin Rhodes, and Mark Thatcher, eds., <i>Beyond Varieties of Capitalism: Conflict, Contradiction, and Complementarities in the European Economy</i> (Oxford and New York: Oxford University Press, 2007); “CSL Search by Example,” <i>Citation Style Editor</i>, 2012, http://editor.citationstyles.org/searchByExample/.<br/>
-Isabela Mares, “Firms and the Welfare State: When, Why, and How Does Social Policy Matter to Employers?,” in <i>Varieties of Capitalism. The Institutional Foundations of Comparative Advantage</i>, ed. Peter A. Hall and David Soskice (New York: Oxford University Press, 2001), 184–213; Martin Fenner et al., “A Data Citation Roadmap for Scholarly Data Repositories,” <i>Sci. Data</i> 6.1 (2019): 28, https://doi.org/10.1038/s41597-019-0031-8.<br/>
+Isabela Mares, “Firms and the Welfare State: When, Why, and How Does Social Policy Matter to Employers?,” in <i>Varieties of Capitalism. The Institutional Foundations of Comparative Advantage</i>, ed. Peter A. Hall and David Soskice (New York: Oxford University Press, 2001), 184–213; Martin Fenner et al., “A Data Citation Roadmap for Scholarly Data Repositories,” <i>Sci. Data</i> 6.1 (2019): 28, https://doi.org/10.1038/s41597-019-0031-8, http://www.nature.com/articles/s41597-019-0031-8.<br/>
<hr/>
-“CSL Search by Example.” <i>Citation Style Editor</i>, 2012. http://editor.citationstyles.org/searchByExample/.<br/>
-Fenner, Martin, Mercè Crosas, Jeffrey S. Grethe, David Kennedy, Henning Hermjakob, Phillippe Rocca-Serra, Gustavo Durand, Robin Berjon, Sebastian Karcher, et al. “A Data Citation Roadmap for Scholarly Data Repositories.” <i>Sci. Data</i> 6.1 (2019): 28. https://doi.org/10.1038/s41597-019-0031-8.<br/>
+“CSL Search by Example”<i>Citation Style Editor</i>, 2012. http://editor.citationstyles.org/searchByExample/.<br/>
+Fenner, Martin, Mercè Crosas, Jeffrey S. Grethe, David Kennedy, Henning Hermjakob, Phillippe Rocca-Serra, Gustavo Durand, Robin Berjon, Sebastian Karcher, et al. “A Data Citation Roadmap for Scholarly Data Repositories”<i>Sci. Data</i> 6.1 (2019): 28. https://doi.org/10.1038/s41597-019-0031-8, http://www.nature.com/articles/s41597-019-0031-8.<br/>
Hancké, Bob, Martin Rhodes, and Mark Thatcher, eds. <i>Beyond Varieties of Capitalism: Conflict, Contradiction, and Complementarities in the European Economy</i>. Oxford and New York: Oxford University Press, 2007.<br/>
-Mares, Isabela. “Firms and the Welfare State: When, Why, and How Does Social Policy Matter to Employers?” Pages 184–213 in <i>Varieties of Capitalism. The Institutional Foundations of Comparative Advantage</i>. Edited by Peter A. Hall and David Soskice. New York: Oxford University Press, 2001.<br/>
+Mares, Isabela. “Firms and the Welfare State: When, Why, and How Does Social Policy Matter to Employers?”Pages 184–213 in <i>Varieties of Capitalism. The Institutional Foundations of Comparative Advantage</i> Edited by Peter A. Hall and David Soskice. New York: Oxford University Press, 2001.<br/>
|
Simplifies the DOI, URL coordination sections per [this comment](0e6c74f#r68836799).
Simplifies the DOI, URL coordination sections per [this comment](0e6c74f#r68836799).
dstark
commented
Mar 16, 2022
There was a problem hiding this comment.
Simplifies the DOI, URL coordination sections per this comment.
|
😃 Your submission passed all our automated tests. Below are some sample citations generated based on your proposed changes: society-of-biblical-literature-fullnote-bibliography.csl (modified style)Bob Hancké, Martin Rhodes, and Mark Thatcher, eds., Beyond Varieties of Capitalism: Conflict, Contradiction, and Complementarities in the European Economy (Oxford and New York: Oxford University Press, 2007); “CSL Search by Example,” Citation Style Editor, 2012, http://editor.citationstyles.org/searchByExample/. Bob Hancké, Martin Rhodes, and Mark Thatcher, eds., <i>Beyond Varieties of Capitalism: Conflict, Contradiction, and Complementarities in the European Economy</i> (Oxford and New York: Oxford University Press, 2007); “CSL Search by Example,” <i>Citation Style Editor</i>, 2012, http://editor.citationstyles.org/searchByExample/.<br/>
-Isabela Mares, “Firms and the Welfare State: When, Why, and How Does Social Policy Matter to Employers?,” in <i>Varieties of Capitalism. The Institutional Foundations of Comparative Advantage</i>, ed. Peter A. Hall and David Soskice (New York: Oxford University Press, 2001), 184–213; Martin Fenner et al., “A Data Citation Roadmap for Scholarly Data Repositories,” <i>Sci. Data</i> 6.1 (2019): 28, https://doi.org/10.1038/s41597-019-0031-8.<br/>
+Isabela Mares, “Firms and the Welfare State: When, Why, and How Does Social Policy Matter to Employers?,” in <i>Varieties of Capitalism. The Institutional Foundations of Comparative Advantage</i>, ed. Peter A. Hall and David Soskice (New York: Oxford University Press, 2001), 184–213; Martin Fenner et al., “A Data Citation Roadmap for Scholarly Data Repositories,” <i>Sci. Data</i> 6.1 (2019): 28, https://doi.org/10.1038/s41597-019-0031-8, http://www.nature.com/articles/s41597-019-0031-8.<br/>
<hr/>
-“CSL Search by Example.” <i>Citation Style Editor</i>, 2012. http://editor.citationstyles.org/searchByExample/.<br/>
-Fenner, Martin, Mercè Crosas, Jeffrey S. Grethe, David Kennedy, Henning Hermjakob, Phillippe Rocca-Serra, Gustavo Durand, Robin Berjon, Sebastian Karcher, et al. “A Data Citation Roadmap for Scholarly Data Repositories.” <i>Sci. Data</i> 6.1 (2019): 28. https://doi.org/10.1038/s41597-019-0031-8.<br/>
+“CSL Search by Example”<i>Citation Style Editor</i>, 2012. http://editor.citationstyles.org/searchByExample/.<br/>
+Fenner, Martin, Mercè Crosas, Jeffrey S. Grethe, David Kennedy, Henning Hermjakob, Phillippe Rocca-Serra, Gustavo Durand, Robin Berjon, Sebastian Karcher, et al. “A Data Citation Roadmap for Scholarly Data Repositories”<i>Sci. Data</i> 6.1 (2019): 28. https://doi.org/10.1038/s41597-019-0031-8, http://www.nature.com/articles/s41597-019-0031-8.<br/>
Hancké, Bob, Martin Rhodes, and Mark Thatcher, eds. <i>Beyond Varieties of Capitalism: Conflict, Contradiction, and Complementarities in the European Economy</i>. Oxford and New York: Oxford University Press, 2007.<br/>
-Mares, Isabela. “Firms and the Welfare State: When, Why, and How Does Social Policy Matter to Employers?” Pages 184–213 in <i>Varieties of Capitalism. The Institutional Foundations of Comparative Advantage</i>. Edited by Peter A. Hall and David Soskice. New York: Oxford University Press, 2001.<br/>
+Mares, Isabela. “Firms and the Welfare State: When, Why, and How Does Social Policy Matter to Employers?”Pages 184–213 in <i>Varieties of Capitalism. The Institutional Foundations of Comparative Advantage</i> Edited by Peter A. Hall and David Soskice. New York: Oxford University Press, 2001.<br/>
|
|
😃 Your submission passed all our automated tests. Below are some sample citations generated based on your proposed changes: society-of-biblical-literature-fullnote-bibliography.csl (modified style)Bob Hancké, Martin Rhodes, and Mark Thatcher, eds., Beyond Varieties of Capitalism: Conflict, Contradiction, and Complementarities in the European Economy (Oxford and New York: Oxford University Press, 2007); “CSL Search by Example,” Citation Style Editor, 2012, http://editor.citationstyles.org/searchByExample/. Bob Hancké, Martin Rhodes, and Mark Thatcher, eds., <i>Beyond Varieties of Capitalism: Conflict, Contradiction, and Complementarities in the European Economy</i> (Oxford and New York: Oxford University Press, 2007); “CSL Search by Example,” <i>Citation Style Editor</i>, 2012, http://editor.citationstyles.org/searchByExample/.<br/>
-Isabela Mares, “Firms and the Welfare State: When, Why, and How Does Social Policy Matter to Employers?,” in <i>Varieties of Capitalism. The Institutional Foundations of Comparative Advantage</i>, ed. Peter A. Hall and David Soskice (New York: Oxford University Press, 2001), 184–213; Martin Fenner et al., “A Data Citation Roadmap for Scholarly Data Repositories,” <i>Sci. Data</i> 6.1 (2019): 28, https://doi.org/10.1038/s41597-019-0031-8.<br/>
+Isabela Mares, “Firms and the Welfare State: When, Why, and How Does Social Policy Matter to Employers?,” in <i>Varieties of Capitalism. The Institutional Foundations of Comparative Advantage</i>, ed. Peter A. Hall and David Soskice (New York: Oxford University Press, 2001), 184–213; Martin Fenner et al., “A Data Citation Roadmap for Scholarly Data Repositories,” <i>Sci. Data</i> 6.1 (2019): 28, https://doi.org/10.1038/s41597-019-0031-8, http://www.nature.com/articles/s41597-019-0031-8.<br/>
<hr/>
-“CSL Search by Example.” <i>Citation Style Editor</i>, 2012. http://editor.citationstyles.org/searchByExample/.<br/>
-Fenner, Martin, Mercè Crosas, Jeffrey S. Grethe, David Kennedy, Henning Hermjakob, Phillippe Rocca-Serra, Gustavo Durand, Robin Berjon, Sebastian Karcher, et al. “A Data Citation Roadmap for Scholarly Data Repositories.” <i>Sci. Data</i> 6.1 (2019): 28. https://doi.org/10.1038/s41597-019-0031-8.<br/>
+“CSL Search by Example”<i>Citation Style Editor</i>, 2012. http://editor.citationstyles.org/searchByExample/.<br/>
+Fenner, Martin, Mercè Crosas, Jeffrey S. Grethe, David Kennedy, Henning Hermjakob, Phillippe Rocca-Serra, Gustavo Durand, Robin Berjon, Sebastian Karcher, et al. “A Data Citation Roadmap for Scholarly Data Repositories”<i>Sci. Data</i> 6.1 (2019): 28. https://doi.org/10.1038/s41597-019-0031-8, http://www.nature.com/articles/s41597-019-0031-8.<br/>
Hancké, Bob, Martin Rhodes, and Mark Thatcher, eds. <i>Beyond Varieties of Capitalism: Conflict, Contradiction, and Complementarities in the European Economy</i>. Oxford and New York: Oxford University Press, 2007.<br/>
-Mares, Isabela. “Firms and the Welfare State: When, Why, and How Does Social Policy Matter to Employers?” Pages 184–213 in <i>Varieties of Capitalism. The Institutional Foundations of Comparative Advantage</i>. Edited by Peter A. Hall and David Soskice. New York: Oxford University Press, 2001.<br/>
+Mares, Isabela. “Firms and the Welfare State: When, Why, and How Does Social Policy Matter to Employers?”Pages 184–213 in <i>Varieties of Capitalism. The Institutional Foundations of Comparative Advantage</i> Edited by Peter A. Hall and David Soskice. New York: Oxford University Press, 2001.<br/>
|
|
@dstark -- is this ready for review? |
|
@adam3smith, it sure is. Did I miss a step in marking it as ready for review? Thanks so much for having a look at it! |
|
No, there were just a number of commits, so just making sure you're done. Will review asap |
github-actions
bot
added
the
waiting-for-response-from-contributor
|
However, there are still conflicts that have to be resolved first. |
|
@denismaier, that sounds good to me. I believe I've resolved the conflict that had cropped up. Please feel free to ask if I can provide anything further. |
github-actions
bot
removed
the
waiting-for-response-from-contributor
|
😃 Your submission passed all our automated tests. Below are some sample citations generated based on your proposed changes: society-of-biblical-literature-fullnote-bibliography.csl (modified style)Bob Hancké, Martin Rhodes, and Mark Thatcher, eds., Beyond Varieties of Capitalism: Conflict, Contradiction, and Complementarities in the European Economy (Oxford and New York: Oxford University Press, 2007); “CSL Search by Example,” Citation Style Editor, 2012, http://editor.citationstyles.org/searchByExample/. Bob Hancké, Martin Rhodes, and Mark Thatcher, eds., <i>Beyond Varieties of Capitalism: Conflict, Contradiction, and Complementarities in the European Economy</i> (Oxford and New York: Oxford University Press, 2007); “CSL Search by Example,” <i>Citation Style Editor</i>, 2012, http://editor.citationstyles.org/searchByExample/.<br/>
-Isabela Mares, “Firms and the Welfare State: When, Why, and How Does Social Policy Matter to Employers?,” in <i>Varieties of Capitalism. The Institutional Foundations of Comparative Advantage</i>, ed. Peter A. Hall and David Soskice (New York: Oxford University Press, 2001), 184–213; Martin Fenner et al., “A Data Citation Roadmap for Scholarly Data Repositories,” <i>Sci. Data</i> 6.1 (2019): 28, https://doi.org/10.1038/s41597-019-0031-8.<br/>
+Isabela Mares, “Firms and the Welfare State: When, Why, and How Does Social Policy Matter to Employers?,” in <i>Varieties of Capitalism. The Institutional Foundations of Comparative Advantage</i>, ed. Peter A. Hall and David Soskice (New York: Oxford University Press, 2001), 184–213; Martin Fenner et al., “A Data Citation Roadmap for Scholarly Data Repositories,” <i>Sci. Data</i> 6.1 (2019): 28, https://doi.org/10.1038/s41597-019-0031-8, http://www.nature.com/articles/s41597-019-0031-8.<br/>
<hr/>
-“CSL Search by Example.” <i>Citation Style Editor</i>, 2012. http://editor.citationstyles.org/searchByExample/.<br/>
-Fenner, Martin, Mercè Crosas, Jeffrey S. Grethe, David Kennedy, Henning Hermjakob, Phillippe Rocca-Serra, Gustavo Durand, Robin Berjon, Sebastian Karcher, et al. “A Data Citation Roadmap for Scholarly Data Repositories.” <i>Sci. Data</i> 6.1 (2019): 28. https://doi.org/10.1038/s41597-019-0031-8.<br/>
+“CSL Search by Example”<i>Citation Style Editor</i>, 2012. http://editor.citationstyles.org/searchByExample/.<br/>
+Fenner, Martin, Mercè Crosas, Jeffrey S. Grethe, David Kennedy, Henning Hermjakob, Phillippe Rocca-Serra, Gustavo Durand, Robin Berjon, Sebastian Karcher, et al. “A Data Citation Roadmap for Scholarly Data Repositories”<i>Sci. Data</i> 6.1 (2019): 28. https://doi.org/10.1038/s41597-019-0031-8, http://www.nature.com/articles/s41597-019-0031-8.<br/>
Hancké, Bob, Martin Rhodes, and Mark Thatcher, eds. <i>Beyond Varieties of Capitalism: Conflict, Contradiction, and Complementarities in the European Economy</i>. Oxford and New York: Oxford University Press, 2007.<br/>
-Mares, Isabela. “Firms and the Welfare State: When, Why, and How Does Social Policy Matter to Employers?” Pages 184–213 in <i>Varieties of Capitalism. The Institutional Foundations of Comparative Advantage</i>. Edited by Peter A. Hall and David Soskice. New York: Oxford University Press, 2001.<br/>
+Mares, Isabela. “Firms and the Welfare State: When, Why, and How Does Social Policy Matter to Employers?”Pages 184–213 in <i>Varieties of Capitalism. The Institutional Foundations of Comparative Advantage</i> Edited by Peter A. Hall and David Soskice. New York: Oxford University Press, 2001.<br/>
|
|
Thanks! But right now the introduction-related changes are still in, right? |
github-actions
bot
added
the
waiting-for-response-from-contributor
|
@adam3smith that's correct. Do I need to submit another file with those changes pulled out? - I wasn't sure if that was the way things went or if you all with approval privileges just declined those changes. Just let me know and I'll be happy to take whatever steps are needed on my end. Thanks so much! |
github-actions
bot
removed
the
waiting-for-response-from-contributor
Yes, if you could just edit this pull request accordingly? It'd take me longer to make sure that I get exactly the right changes in and out. Thanks! |
github-actions
bot
added
the
waiting-for-response-from-contributor
Removes support for frontmatter citations based on `part-title`. Adds quotes around s.v. locators per SBL style.
dstark
commented
Jun 28, 2022
|
😃 Your submission passed all our automated tests. Below are some sample citations generated based on your proposed changes: society-of-biblical-literature-fullnote-bibliography.csl (modified style)Bob Hancké, Martin Rhodes, and Mark Thatcher, eds., Beyond Varieties of Capitalism: Conflict, Contradiction, and Complementarities in the European Economy (Oxford and New York: Oxford University Press, 2007); “CSL Search by Example,” Citation Style Editor, 2012, http://editor.citationstyles.org/searchByExample/. Bob Hancké, Martin Rhodes, and Mark Thatcher, eds., <i>Beyond Varieties of Capitalism: Conflict, Contradiction, and Complementarities in the European Economy</i> (Oxford and New York: Oxford University Press, 2007); “CSL Search by Example,” <i>Citation Style Editor</i>, 2012, http://editor.citationstyles.org/searchByExample/.<br/>
-Isabela Mares, “Firms and the Welfare State: When, Why, and How Does Social Policy Matter to Employers?,” in <i>Varieties of Capitalism. The Institutional Foundations of Comparative Advantage</i>, ed. Peter A. Hall and David Soskice (New York: Oxford University Press, 2001), 184–213; Martin Fenner et al., “A Data Citation Roadmap for Scholarly Data Repositories,” <i>Sci. Data</i> 6.1 (2019): 28, https://doi.org/10.1038/s41597-019-0031-8.<br/>
+Isabela Mares, “Firms and the Welfare State: When, Why, and How Does Social Policy Matter to Employers?,” in <i>Varieties of Capitalism. The Institutional Foundations of Comparative Advantage</i>, ed. Peter A. Hall and David Soskice (New York: Oxford University Press, 2001), 184–213; Martin Fenner et al., “A Data Citation Roadmap for Scholarly Data Repositories,” <i>Sci. Data</i> 6.1 (2019): 28, https://doi.org/10.1038/s41597-019-0031-8, http://www.nature.com/articles/s41597-019-0031-8.<br/>
<hr/>
“CSL Search by Example.” <i>Citation Style Editor</i>, 2012. http://editor.citationstyles.org/searchByExample/.<br/>
-Fenner, Martin, Mercè Crosas, Jeffrey S. Grethe, David Kennedy, Henning Hermjakob, Phillippe Rocca-Serra, Gustavo Durand, Robin Berjon, Sebastian Karcher, et al. “A Data Citation Roadmap for Scholarly Data Repositories.” <i>Sci. Data</i> 6.1 (2019): 28. https://doi.org/10.1038/s41597-019-0031-8.<br/>
+Fenner, Martin, Mercè Crosas, Jeffrey S. Grethe, David Kennedy, Henning Hermjakob, Phillippe Rocca-Serra, Gustavo Durand, Robin Berjon, Sebastian Karcher, et al. “A Data Citation Roadmap for Scholarly Data Repositories.” <i>Sci. Data</i> 6.1 (2019): 28. https://doi.org/10.1038/s41597-019-0031-8, http://www.nature.com/articles/s41597-019-0031-8.<br/>
Hancké, Bob, Martin Rhodes, and Mark Thatcher, eds. <i>Beyond Varieties of Capitalism: Conflict, Contradiction, and Complementarities in the European Economy</i>. Oxford and New York: Oxford University Press, 2007.<br/>
Mares, Isabela. “Firms and the Welfare State: When, Why, and How Does Social Policy Matter to Employers?” Pages 184–213 in <i>Varieties of Capitalism. The Institutional Foundations of Comparative Advantage</i>. Edited by Peter A. Hall and David Soskice. New York: Oxford University Press, 2001.<br/>
|
|
@adam3smith, I think this is ready to go. While I was removing the frontmatter citation material, I took the liberty of adding quotes in one place where I noticed they had been lacking per SBL style. If I can provide anything further, please feel free to ask. Thank you so much! |
github-actions
bot
removed
the
waiting-for-response-from-contributor
|
😃 Your submission passed all our automated tests. Below are some sample citations generated based on your proposed changes: society-of-biblical-literature-fullnote-bibliography.csl (modified style)Bob Hancké, Martin Rhodes, and Mark Thatcher, eds., Beyond Varieties of Capitalism: Conflict, Contradiction, and Complementarities in the European Economy (Oxford and New York: Oxford University Press, 2007); “CSL Search by Example,” Citation Style Editor, 2012, http://editor.citationstyles.org/searchByExample/. Bob Hancké, Martin Rhodes, and Mark Thatcher, eds., <i>Beyond Varieties of Capitalism: Conflict, Contradiction, and Complementarities in the European Economy</i> (Oxford and New York: Oxford University Press, 2007); “CSL Search by Example,” <i>Citation Style Editor</i>, 2012, http://editor.citationstyles.org/searchByExample/.<br/>
-Isabela Mares, “Firms and the Welfare State: When, Why, and How Does Social Policy Matter to Employers?,” in <i>Varieties of Capitalism. The Institutional Foundations of Comparative Advantage</i>, ed. Peter A. Hall and David Soskice (New York: Oxford University Press, 2001), 184–213; Martin Fenner et al., “A Data Citation Roadmap for Scholarly Data Repositories,” <i>Sci. Data</i> 6.1 (2019): 28, https://doi.org/10.1038/s41597-019-0031-8.<br/>
+Isabela Mares, “Firms and the Welfare State: When, Why, and How Does Social Policy Matter to Employers?,” in <i>Varieties of Capitalism. The Institutional Foundations of Comparative Advantage</i>, ed. Peter A. Hall and David Soskice (New York: Oxford University Press, 2001), 184–213; Martin Fenner et al., “A Data Citation Roadmap for Scholarly Data Repositories,” <i>Sci. Data</i> 6.1 (2019): 28, https://doi.org/10.1038/s41597-019-0031-8, http://www.nature.com/articles/s41597-019-0031-8.<br/>
<hr/>
“CSL Search by Example.” <i>Citation Style Editor</i>, 2012. http://editor.citationstyles.org/searchByExample/.<br/>
-Fenner, Martin, Mercè Crosas, Jeffrey S. Grethe, David Kennedy, Henning Hermjakob, Phillippe Rocca-Serra, Gustavo Durand, Robin Berjon, Sebastian Karcher, et al. “A Data Citation Roadmap for Scholarly Data Repositories.” <i>Sci. Data</i> 6.1 (2019): 28. https://doi.org/10.1038/s41597-019-0031-8.<br/>
+Fenner, Martin, Mercè Crosas, Jeffrey S. Grethe, David Kennedy, Henning Hermjakob, Phillippe Rocca-Serra, Gustavo Durand, Robin Berjon, Sebastian Karcher, et al. “A Data Citation Roadmap for Scholarly Data Repositories.” <i>Sci. Data</i> 6.1 (2019): 28. https://doi.org/10.1038/s41597-019-0031-8, http://www.nature.com/articles/s41597-019-0031-8.<br/>
Hancké, Bob, Martin Rhodes, and Mark Thatcher, eds. <i>Beyond Varieties of Capitalism: Conflict, Contradiction, and Complementarities in the European Economy</i>. Oxford and New York: Oxford University Press, 2007.<br/>
Mares, Isabela. “Firms and the Welfare State: When, Why, and How Does Social Policy Matter to Employers?” Pages 184–213 in <i>Varieties of Capitalism. The Institutional Foundations of Comparative Advantage</i>. Edited by Peter A. Hall and David Soskice. New York: Oxford University Press, 2001.<br/>
|
Updated the last-updated time stamp so that it's not something prior to the version currently in the repository. Sorry I missed that yesterday.
dstark
commented
Jun 29, 2022
|
😃 Your submission passed all our automated tests. Below are some sample citations generated based on your proposed changes: society-of-biblical-literature-fullnote-bibliography.csl (modified style)Bob Hancké, Martin Rhodes, and Mark Thatcher, eds., Beyond Varieties of Capitalism: Conflict, Contradiction, and Complementarities in the European Economy (Oxford and New York: Oxford University Press, 2007); “CSL Search by Example,” Citation Style Editor, 2012, http://editor.citationstyles.org/searchByExample/. Bob Hancké, Martin Rhodes, and Mark Thatcher, eds., <i>Beyond Varieties of Capitalism: Conflict, Contradiction, and Complementarities in the European Economy</i> (Oxford and New York: Oxford University Press, 2007); “CSL Search by Example,” <i>Citation Style Editor</i>, 2012, http://editor.citationstyles.org/searchByExample/.<br/>
-Isabela Mares, “Firms and the Welfare State: When, Why, and How Does Social Policy Matter to Employers?,” in <i>Varieties of Capitalism. The Institutional Foundations of Comparative Advantage</i>, ed. Peter A. Hall and David Soskice (New York: Oxford University Press, 2001), 184–213; Martin Fenner et al., “A Data Citation Roadmap for Scholarly Data Repositories,” <i>Sci. Data</i> 6.1 (2019): 28, https://doi.org/10.1038/s41597-019-0031-8.<br/>
+Isabela Mares, “Firms and the Welfare State: When, Why, and How Does Social Policy Matter to Employers?,” in <i>Varieties of Capitalism. The Institutional Foundations of Comparative Advantage</i>, ed. Peter A. Hall and David Soskice (New York: Oxford University Press, 2001), 184–213; Martin Fenner et al., “A Data Citation Roadmap for Scholarly Data Repositories,” <i>Sci. Data</i> 6.1 (2019): 28, https://doi.org/10.1038/s41597-019-0031-8, http://www.nature.com/articles/s41597-019-0031-8.<br/>
<hr/>
“CSL Search by Example.” <i>Citation Style Editor</i>, 2012. http://editor.citationstyles.org/searchByExample/.<br/>
-Fenner, Martin, Mercè Crosas, Jeffrey S. Grethe, David Kennedy, Henning Hermjakob, Phillippe Rocca-Serra, Gustavo Durand, Robin Berjon, Sebastian Karcher, et al. “A Data Citation Roadmap for Scholarly Data Repositories.” <i>Sci. Data</i> 6.1 (2019): 28. https://doi.org/10.1038/s41597-019-0031-8.<br/>
+Fenner, Martin, Mercè Crosas, Jeffrey S. Grethe, David Kennedy, Henning Hermjakob, Phillippe Rocca-Serra, Gustavo Durand, Robin Berjon, Sebastian Karcher, et al. “A Data Citation Roadmap for Scholarly Data Repositories.” <i>Sci. Data</i> 6.1 (2019): 28. https://doi.org/10.1038/s41597-019-0031-8, http://www.nature.com/articles/s41597-019-0031-8.<br/>
Hancké, Bob, Martin Rhodes, and Mark Thatcher, eds. <i>Beyond Varieties of Capitalism: Conflict, Contradiction, and Complementarities in the European Economy</i>. Oxford and New York: Oxford University Press, 2007.<br/>
Mares, Isabela. “Firms and the Welfare State: When, Why, and How Does Social Policy Matter to Employers?” Pages 184–213 in <i>Varieties of Capitalism. The Institutional Foundations of Comparative Advantage</i>. Edited by Peter A. Hall and David Soskice. New York: Oxford University Press, 2001.<br/>
|
|
Thanks -- no need to touch the update stamp, btw. Once merged the update field gets set automatically for the version of the style in the current release branch of the repository (i.e. v1.0.2) |
That's nice to know. Thanks for the additional information, and the merge! |
|
@denismaier, could you point me to the issue you mentioned opening about adding a |
|
sure, here it is: citation-style-language/schema#414 |
Thanks so much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SBL style routinely wants a comma after an abbreviation-based citation (facilitated via annote) when the locator is sub-verbo. Other situations (sections, pages) sometimes (or often) don't include a comma.