Skip to content

Commit

Permalink
Re-indent CSL styles
Browse files Browse the repository at this point in the history
  • Loading branch information
@dstark @actions-user
dstark authored and actions-user committed Mar 1, 2022
1 parent 2f0a612 commit 0e6c74f
Showing 1 changed file with 4 additions and 6 deletions.
10 changes: 4 additions & 6 deletions society-of-biblical-literature-fullnote-bibliography.csl
View file
Original file line number Diff line number Diff line change
Expand Up @@ -990,10 +990,9 @@
<text macro="archive-note"/>
</else-if>
</choose>
<!-- SBL style uses DOIs and URLs when the resource is electronic. SBLHS2 §§ 6.1.6, 6.2.25, 6.3.10, 6.4.13–14. If a resource has physical dimensions, however, it is not electronic. So, DOI or URL output should be bypassed. -->
<!-- SBL style uses DOIs and URLs when the resource is electronic. SBLHS2 §§ 6.1.6, 6.2.25, 6.3.10, 6.4.13&#8211;14. If a resource has physical dimensions, however, it is not electronic. So, DOI or URL output should be bypassed. -->
<choose>
<if variable="dimensions">
</if>
<if variable="dimensions"></if>
<else>
<choose>
<if variable="DOI">
Expand All @@ -1018,10 +1017,9 @@
<text macro="archive"/>
</else-if>
</choose>
<!-- SBL style uses DOIs and URLs when the resource is electronic. SBLHS2 §§ 6.1.6, 6.2.25, 6.3.10, 6.4.13–14. If a resource has physical dimensions, however, it is not electronic. So, DOI or URL output should be bypassed. -->
<!-- SBL style uses DOIs and URLs when the resource is electronic. SBLHS2 §§ 6.1.6, 6.2.25, 6.3.10, 6.4.13&#8211;14. If a resource has physical dimensions, however, it is not electronic. So, DOI or URL output should be bypassed. -->
<choose>
<if variable="dimensions">
</if>
<if variable="dimensions"></if>
<else>
<choose>
<if variable="DOI">

This comment has been minimized.

Sign in to view

Copy link
@dstark

dstark Mar 14, 2022

Author Contributor

Actually, SBLHS2 §6.3.10 prefers DOIs to URLs but allows both to be included should someone want to. So, it seems these lines should be something like

<if variable="DOI URL" match="any"> <group delimiter=", "> <text variable="DOI" prefix="https://doi.org/"/> <text variable="URL"/> </group> </if>

But I can't seem to get the URL variable to be included, even when there's something in that field in Zotero (5.0.96.3). If I substitute for URL something nonsensical but that works elsewhere like container-title, the container-title does do the either-or and both-and scenarios properly (e.g., "https://doi.org/10.2307/3260389, Journal of Biblical Literature", https://doi.org/10.2307/3260389", "Journal of Biblical Literature", and nothing at all if both fields are blank). So, I'm not sure what it is about the URL variable that's causing it not to appear.

@adam3smith or @bwiernik, would you have any thoughts about what it is that I'm missing here?

This comment has been minimized.

Sign in to view

Copy link
@denismaier

denismaier Mar 16, 2022 •
edited
Loading

Member

@dstark I don't know why that happens, but if you want to render both the DOI and the URL, you can just remove the choose element. I don't see why you would want a conditional here at all. Does this work?

<group delimiter=", "> 
  <text variable="DOI" prefix="https://doi.org/"/> 
  <text variable="URL"/> 
</group>

This comment has been minimized.

Sign in to view

Copy link
@dstark

dstark Mar 16, 2022

Author Contributor

@denismaier, thanks. You're right that the <choose> element is superfluous. So, your recommendation is a simpler (and therefore better) way to get to the problem I mention above.

This comment has been minimized.

Sign in to view

Copy link
@adam3smith

adam3smith Mar 16, 2022

Member

You're likely seeing Zotero's standard URL behavior. Zotero treats an item as not having a URL (even if one is in the URL field) if it is an article with a page range. You can toggle that behavior under Cite --> Styles by checking the "Include URL" checkbox.

This comment has been minimized.

Sign in to view

Copy link
@dstark

dstark Mar 16, 2022

Author Contributor

Yep, sure enough, @adam3smith. Works like a charm now. Thanks so much!

[Insert catchy proverb about how many things would be better if user error weren't a factor. :-)]
Expand Down

0 comments on commit 0e6c74f

Please sign in to comment.