-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/131 Enable R-CMD-check on Git-Hub Actions #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 16, 2020
GegznaV
added
the
Topic: CI 🌵
Related to continuous integracion (CI), automatic builds and checking.
label
Jun 16, 2020
|
- Create separate `.gitignore` files for top-level folder and for `hyperSpec` folder. This prepares to get rid o make (see #132) - Organize entries by topic.
After converting datasets into "static" ones, NAMESPACE could be |
This pull request is ready to be merged ✔️. |
This was referenced Jun 16, 2020
GegznaV
changed the title
Enable R-CMD-check on Git-Hub Actions
Feature/131 Enable R-CMD-check on Git-Hub Actions
Jun 17, 2020
cbeleites
approved these changes
Jun 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Topic: CI 🌵
Related to continuous integracion (CI), automatic builds and checking.
Topic: datasets 📅
Related to datasets in hyperSpec
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make. The changes in this PR enable building package by using tools that are integrated with RStudio (devtools, etc.). Thus, it is related to Get (mostly) rid of
make
#132.Continuous integration (CI) is enabled on GitHub Actions (closes Use Continuous Integration (CI) service to automatically check hyperSpec package #131) and R-CMD-check passes on:
(See the results at the bottom of this page). This PR does the same as point 5 in Removed make, static datasets, Rmd vignettes, enabled CI and pkgdown #153 jus working directory is changed to
./hyperSpec
.Datasets. The small datasets and dataset
chondro
are converted to "static" versions. This addresses most of the issues Convert small data sets to "static" versions #137 (I checked the boxes in Convert small data sets to "static" versions #137 that are completed and others may be polished later).Note: PR #153 will be closed without merging in favor of this (#159), #147, and some other PRs.