Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/131 Enable R-CMD-check on Git-Hub Actions #159

Merged
merged 7 commits into from
Jun 21, 2020
Merged

Feature/131 Enable R-CMD-check on Git-Hub Actions #159

merged 7 commits into from
Jun 21, 2020

Conversation

GegznaV
Copy link
Collaborator

@GegznaV GegznaV commented Jun 16, 2020

  1. Make. The changes in this PR enable building package by using tools that are integrated with RStudio (devtools, etc.). Thus, it is related to Get (mostly) rid of make #132.

  2. Continuous integration (CI) is enabled on GitHub Actions (closes Use Continuous Integration (CI) service to automatically check hyperSpec package #131) and R-CMD-check passes on:

    • Windows + R devel version (it is set to fail on errors only for R-devel)
    • Windows + R current version (it is set to fail on warnings for R current and old release)
    • macOS + R current version
    • Ubuntu + R current version
    • Ubuntu + R old release

    (See the results at the bottom of this page). This PR does the same as point 5 in Removed make, static datasets, Rmd vignettes, enabled CI and pkgdown #153 jus working directory is changed to ./hyperSpec.

  3. Datasets. The small datasets and dataset chondro are converted to "static" versions. This addresses most of the issues Convert small data sets to "static" versions #137 (I checked the boxes in Convert small data sets to "static" versions #137 that are completed and others may be polished later).

Note: PR #153 will be closed without merging in favor of this (#159), #147, and some other PRs.

@GegznaV GegznaV added the Topic: CI 🌵 Related to continuous integracion (CI), automatic builds and checking. label Jun 16, 2020
@GegznaV
Copy link
Collaborator Author

GegznaV commented Jun 16, 2020

The checking is expected to fail due to issues related to Roxygenation and NAMESPACE. They are discussed in #153 (comment).

Could we track changes in NAMESPACE temporarily until #160 is solved? This is a small cost for having CI that works.

GegznaV added 4 commits June 16, 2020 18:39
- Create separate `.gitignore` files for top-level folder and for `hyperSpec` folder. This prepares to get rid o make (see #132)
- Organize entries by topic.
@GegznaV
Copy link
Collaborator Author

GegznaV commented Jun 16, 2020

After converting datasets into "static" ones, NAMESPACE could be .gitignored. But see #160 (comment).

@GegznaV
Copy link
Collaborator Author

GegznaV commented Jun 16, 2020

This pull request is ready to be merged ✔️.

@cbeleites cbeleites merged commit 460e56d into cbeleites:develop Jun 21, 2020
@GegznaV GegznaV deleted the enable_r_cmd_check branch June 21, 2020 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Topic: CI 🌵 Related to continuous integracion (CI), automatic builds and checking. Topic: datasets 📅 Related to datasets in hyperSpec
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use Continuous Integration (CI) service to automatically check hyperSpec package
2 participants