Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Git-ignore NAMESPACE + build vignettes + pass automatic R-CMD-check #160

Closed
GegznaV opened this issue Jun 16, 2020 · 4 comments
Closed

Git-ignore NAMESPACE + build vignettes + pass automatic R-CMD-check #160

GegznaV opened this issue Jun 16, 2020 · 4 comments
Labels
Topic: CI 🌵 Related to continuous integracion (CI), automatic builds and checking.

Comments

@GegznaV
Copy link
Collaborator

GegznaV commented Jun 16, 2020

Remove issues that do not allow git-ignoring the NAMESPACE file and passing automatic R-CMD-check. More details in #153 (comment).

Related: #159
@GegznaV GegznaV added the Topic: CI 🌵 Related to continuous integracion (CI), automatic builds and checking. label Jun 16, 2020
@GegznaV GegznaV mentioned this issue Jun 16, 2020
Merged
@GegznaV
Copy link
Collaborator Author

GegznaV commented Jun 16, 2020

After converting datasets into "static" ones, NAMESPACE could be .gitignored (see #159). Still, I think there will be some issues after Rmd vignettes are merged (PR #147). So do not close this issue until PR #147 is merged or until we are sure that the vignettes will not reveal this issue again.

@GegznaV
Copy link
Collaborator Author

GegznaV commented Jun 16, 2020

Bullet 3 in #153 (comment) may also be relevant:

the error looks as if we're missing an @import. I'll have to look into this.

@GegznaV GegznaV changed the title Remove isses to Git-ignore NAMESPACE and pass automatic R-CMD-check Git-ignore NAMESPACE + build vignettes + pass automatic R-CMD-check Jun 16, 2020
@GegznaV
Copy link
Collaborator Author

GegznaV commented Jun 19, 2020

Related: #163 (comment)

@cbeleites
Copy link
Owner

I'll close this now:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Topic: CI 🌵 Related to continuous integracion (CI), automatic builds and checking.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cbeleites @GegznaV