Fix wrong context for joining cluster #282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bschimke95
force-pushed
the
bschimke95/fix-bootstrap-context
branch
from
770c826 to
b4f412e
Compare
bschimke95
changed the title
neoaggelos
approved these changes
Apr 2, 2024
The server-side context does not get the deadline from the client. Instead it will just be cancelled when the client context is cancelled. So, instead of querying the context from the context we do not set a deadline at all on the server-side and let't the client handle this.
bschimke95
force-pushed
the
bschimke95/fix-bootstrap-context
branch
from
b4f412e to
1a60cfd
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The server-side context does not get the deadline from the client. Instead it will just be cancelled when the client context is cancelled. So, instead of querying the context from the context we do not set a deadline at all on the server-side and let't the client handle this.