Wrap microcluster app and API endpoints #283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
bschimke95
approved these changes
Apr 3, 2024
| // Endpoints returns the list of endpoints for a given microcluster app. | ||
| func Endpoints(app *microcluster.MicroCluster) []rest.Endpoint { | ||
| func (e *Endpoints) Endpoints() []rest.Endpoint { |
There was a problem hiding this comment.
nit: Endpoints.Endpoints() reads a bit weird. Maybe call this API?
There was a problem hiding this comment.
Usage is api.New(...).Endpoints(), should we maybe rename the type to *api.API?
| @@ -55,10 +55,10 @@ func New(ctx context.Context, cfg Config) (*App, error) { | |||
| func (a *App) Run(customHooks *config.Hooks) error { | |||
| // TODO: consider improving API for overriding hooks. | |||
There was a problem hiding this comment.
nit: is this still relevant? Seems outdated.
There was a problem hiding this comment.
yeah, we now pass a *config.Hooks and selectively apply some of the non-nil hooks. which works ok, as we do hange some hooks in a couple of tests.
but this is not too clean, i'd keep the TODO around for the future
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Capture all required state for the microcluster and the API endpoint implementation in structs.
Changes
*app.Appnow wraps the microcluster app and the snap interface*app.Appnow implementsapi.Provider*api.Endpointsnow wraps the required provider (to have access to the snap and microcluster app), and implements the API endpointswrapHandlerWithMicroclusterclosure, and retrieving the snap through the server context.Notes
This will allow us to add more configs to the application, and works towards making it easier to write tests for our API endpoints